Skip to content

Commit f4f648b

Browse files
committed
Fix lint issue with refactoring improvement.
1 parent b8b84af commit f4f648b

File tree

1 file changed

+15
-12
lines changed
  • instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai

1 file changed

+15
-12
lines changed

instrumentation-genai/opentelemetry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/tool_call_wrapper.py

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,19 @@ def _create_function_span_attributes(
7070
return result
7171

7272

73+
def _record_function_call_argument(
74+
span,
75+
param_name,
76+
param_value,
77+
include_values):
78+
attribute_prefix = f"code.function.parameters.{param_name}"
79+
type_attribute = f"{attribute_prefix}.type"
80+
span.set_attribute(type_attribute, type(param_value).__name__)
81+
if include_values:
82+
value_attribute = f"{attribute_prefix}.value"
83+
span.set_attribute(value_attribute, _to_otel_value(param_value))
84+
85+
7386
def _record_function_call_arguments(
7487
otel_wrapper, wrapped_function, function_args, function_kwargs
7588
):
@@ -82,19 +95,9 @@ def _record_function_call_arguments(
8295
param_name = f"args[{index}]"
8396
if index < len(params):
8497
param_name = params[index].name
85-
attribute_prefix = f"code.function.parameters.{param_name}"
86-
type_attribute = f"{attribute_prefix}.type"
87-
span.set_attribute(type_attribute, type(entry).__name__)
88-
if include_values:
89-
value_attribute = f"{attribute_prefix}.value"
90-
span.set_attribute(value_attribute, _to_otel_value(entry))
98+
_record_function_call_argument(span, param_name, entry, include_values)
9199
for key, value in function_kwargs.items():
92-
attribute_prefix = f"code.function.parameters.{key}"
93-
type_attribute = f"{attribute_prefix}.type"
94-
span.set_attribute(type_attribute, type(value).__name__)
95-
if include_values:
96-
value_attribute = f"{attribute_prefix}.value"
97-
span.set_attribute(value_attribute, _to_otel_value(value))
100+
_record_function_call_argument(span, key, value, include_values)
98101

99102

100103
def _record_function_call_result(otel_wrapper, wrapped_function, result):

0 commit comments

Comments
 (0)