test(fastapi): added span assertions for custom api route tests

Author: lannuttia

instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py

@@ -191,11 +191,9 @@ def client_response_hook(span: Span, scope: dict[str, Any], message: dict[str, A
 import fastapi
 from starlette.applications import Starlette
 from starlette.middleware.errors import ServerErrorMiddleware
-
 from starlette.routing import Match, Route
 from starlette.types import ASGIApp, Receive, Scope, Send
 
-
 from opentelemetry.instrumentation._semconv import (
     _get_schema_url,
     _OpenTelemetrySemanticConventionStability,

instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py

@@ -20,7 +20,7 @@
 import weakref as _weakref
 from contextlib import ExitStack
 from timeit import default_timer
-from typing import Any, cast
+from typing import Any, Final, cast
 from unittest.mock import Mock, call, patch
 
 import fastapi
@@ -341,15 +341,27 @@ def test_sub_app_fastapi_call(self):
             span.attributes[HTTP_URL],
         )
 
-
     def test_custom_api_router(self):
         """
         This test is to ensure that custom API routers the OpenTelemetryMiddleware does not cause issues with
         custom API routers that depend on non-standard fields on the ASGI scope.
         """
-        resp = self._client.get("/custom-router/success")
-        self.assertEqual(resp.status_code, 200)
-
+        resp: Final = self._client.get("/custom-router/success")
+        spans: Final = self.memory_exporter.get_finished_spans()
+        spans_with_http_attributes = [
+            span
+            for span in spans
+            if (HTTP_URL in span.attributes or HTTP_TARGET in span.attributes)
+        ]
+        self.assertEqual(200, resp.status_code)
+        for span in spans_with_http_attributes:
+            self.assertEqual(
+                "/custom-router/success", span.attributes[HTTP_TARGET]
+            )
+            self.assertEqual(
+                "https://testserver/custom-router/success",
+                span.attributes[HTTP_URL],
+            )
 
     def test_host_fastapi_call(self):
         client = TestClient(self._app, base_url="https://testserver2:443")