- 
                Notifications
    
You must be signed in to change notification settings  - Fork 803
 
Description
A lot of code imports semantic conventions attributes from opentelemetry.semconv.trace.SpanAttributes instead of the preferred opentelemetry.semconv.attributes and opentelemetry.semconv.incubating.
This issue it is only about removing usage of SpanAttributes while not changing the output of the telemetry. If some attributes (e.g. in messaging) are not available anymore just keep using the one from SpanAttributes.
Here's the list of of packages found grepping SpanAttributes on a recent checkout. Some packages may be more easy than others to convert since there may just be a couple of instances to fix.
People willing to help with this, state in the issue on what package you are going to work and you have 1 week to create a PR, after that we'll consider the package available to others.
The PR message should contains Refs #3475 instead of Fixes #3475.
Updated of instrumentation specific tests in tests/opentelemetry-docker-tests should probably go on par with the conversion of the instrumentation package.
- exporter/opentelemetry-exporter-richconsole refactor(richconsole): replaces SpanAttributes by semconv attributes #3501
 - instrumentation/opentelemetry-instrumentation-aio-pika
 - instrumentation/opentelemetry-instrumentation-aiohttp-client Refactor: replace use of SpanAttributes in test-instrumentation-aiohttp-client #3502
 - instrumentation/opentelemetry-instrumentation-aiohttp-server Refactor: replace use of SpanAttributes in test-instrumentation-aiohttp-server #3504
 - instrumentation/opentelemetry-instrumentation-aiopg
 - instrumentation/opentelemetry-instrumentation-asgi
 - instrumentation/opentelemetry-instrumentation-asyncpg Refactor asyncpg : replace uses of SpanAttributes with opentelemetry.semconv.attributes #3505
 - instrumentation/opentelemetry-instrumentation-aws-lambda
 - instrumentation/opentelemetry-instrumentation-boto
 - instrumentation/opentelemetry-instrumentation-boto3sqs
 - instrumentation/opentelemetry-instrumentation-botocore
 - instrumentation/opentelemetry-instrumentation-cassandra
 - instrumentation/opentelemetry-instrumentation-celery
 - instrumentation/opentelemetry-instrumentation-confluent-kafka
 - instrumentation/opentelemetry-instrumentation-dbapi
 - instrumentation/opentelemetry-instrumentation-django
 - instrumentation/opentelemetry-instrumentation-elasticsearch refactor(elasticsearch) Replace SpanAttributes by semconv attributes #3503 Refactor (elasticsearch) to use semconv incubating attributes in tests. #3532
 - instrumentation/opentelemetry-instrumentation-falcon
 -  instrumentation/opentelemetry-instrumentation-fastapi refactor(fastapi): replace uses of 
SpanAttributeswithopentelemetry.semconv.attributes#3491 - instrumentation/opentelemetry-instrumentation-flask
 - instrumentation/opentelemetry-instrumentation-grpc
 - instrumentation/opentelemetry-instrumentation-httpx
 - instrumentation/opentelemetry-instrumentation-kafka-python
 - instrumentation/opentelemetry-instrumentation-mysql
 - instrumentation/opentelemetry-instrumentation-mysqlclient/
 - instrumentation/opentelemetry-instrumentation-pika
 - instrumentation/opentelemetry-instrumentation-pymemcache
 - instrumentation/opentelemetry-instrumentation-pymongo
 - instrumentation/opentelemetry-instrumentation-pymysql
 - instrumentation/opentelemetry-instrumentation-pyramid
 - instrumentation/opentelemetry-instrumentation-redis
 - instrumentation/opentelemetry-instrumentation-remoulade
 - instrumentation/opentelemetry-instrumentation-requests requests: migrate from SpanAttributes #3493
 - instrumentation/opentelemetry-instrumentation-sqlalchemy
 - instrumentation/opentelemetry-instrumentation-starlette
 - instrumentation/opentelemetry-instrumentation-tornado
 - instrumentation/opentelemetry-instrumentation-tortoiseorm
 - instrumentation/opentelemetry-instrumentation-urllib
 - instrumentation/opentelemetry-instrumentation-wsgi
 - opentelemetry-instrumentation
 - util/opentelemetry-util-http
 
Entries per file to fix git grep SpanAttributes | cut -d : -f1 | uniq -c or per package to fix git grep SpanAttributes | cut -d : -f1 | cut -d / -f2 | uniq -c.