-
Notifications
You must be signed in to change notification settings - Fork 822
Description
What problem do you want to solve?
DB-API Instrumentor's wrap_connect is a common util used by concrete db client framework instrumentors (e.g. psycopg2, mysqlclient) to wrap database connections to instrument queries.
trace_integration is a thin wrapper around wrap_connect. It has been documented for a long time so it's likely being used manually in the wild, just not by instrumentors e.g. auto-instrumentation. trace_integration accepts all the same args as wrap_connect except commenter_options.
Describe the solution you'd like
Update trace_integration to accept option commenter_options for consistent behaviour. The documentation (readthedocs) should also be updated.
Describe alternatives you've considered
No response
Additional Context
Noticed during documentation update in #3720
Would you like to implement a fix?
None
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.