diff --git a/CHANGELOG.md b/CHANGELOG.md index 7fa1ab2ba3..bfa2f7e66e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ([#2860](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2860)) - `opentelemetry-instrumentation-aiokafka` Add instrumentor and auto instrumentation support for aiokafka ([#2082](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2082)) +- `opentelemetry-instrumentation-system-metrics` Fix instrument types in system metrics + ([#2865](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2865)) ## Version 1.27.0/0.48b0 () diff --git a/instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py b/instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py index 1b9a36c4cb..6cdfac5e46 100644 --- a/instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py +++ b/instrumentation/opentelemetry-instrumentation-system-metrics/src/opentelemetry/instrumentation/system_metrics/__init__.py @@ -331,11 +331,10 @@ def _instrument(self, **kwargs): ) if "system.network.connections" in self._config: - self._meter.create_observable_up_down_counter( + self._meter.create_observable_gauge( name="system.network.connections", callbacks=[self._get_system_network_connections], description="System network connections", - unit="connections", ) if "system.thread_count" in self._config: @@ -346,7 +345,7 @@ def _instrument(self, **kwargs): ) if "process.runtime.memory" in self._config: - self._meter.create_observable_up_down_counter( + self._meter.create_observable_gauge( name=f"process.runtime.{self._python_implementation}.memory", callbacks=[self._get_runtime_memory], description=f"Runtime {self._python_implementation} memory", @@ -367,15 +366,14 @@ def _instrument(self, **kwargs): "The process.runtime.gc_count metric won't be collected because the interpreter is PyPy" ) else: - self._meter.create_observable_counter( + self._meter.create_observable_gauge( name=f"process.runtime.{self._python_implementation}.gc_count", callbacks=[self._get_runtime_gc_count], description=f"Runtime {self._python_implementation} GC count", - unit="bytes", ) if "process.runtime.thread_count" in self._config: - self._meter.create_observable_up_down_counter( + self._meter.create_observable_gauge( name=f"process.runtime.{self._python_implementation}.thread_count", callbacks=[self._get_runtime_thread_count], description="Runtime active threads count", @@ -398,7 +396,7 @@ def _instrument(self, **kwargs): ) if "process.open_file_descriptor.count" in self._config: - self._meter.create_observable_up_down_counter( + self._meter.create_observable_gauge( name="process.open_file_descriptor.count", callbacks=[self._get_open_file_descriptors], description="Number of file descriptors in use by the process.",