Skip to content

Conversation

@xrmx
Copy link
Contributor

@xrmx xrmx commented Feb 20, 2025

Description

Since genai instrumentations are released on their own we cannot have a fixed required version on this side.
While at it add vertexai to the list of excluded packages since:

  • it has not been released yet
  • the name is already claimed by openllmetry

Fixes #3251

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e generate

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

…entations versions

Since genai instrumentations are released on their own we cannot have a
fixed required version on this side.
While at it add vertexai to the list of excluded packages since:
- it has not been released yet
- the name is already claimed by openllmetry
@xrmx xrmx requested a review from a team as a code owner February 20, 2025 15:25
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 20, 2025
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌🏻

@xrmx xrmx enabled auto-merge (squash) February 21, 2025 08:34
@xrmx xrmx merged commit e4a5b54 into open-telemetry:main Feb 21, 2025
694 checks passed
xrmx added a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Feb 21, 2025
…entations versions (open-telemetry#3278)

* scripts/generate_instrumentation_bootstrap: don't force genai instrumentations versions

Since genai instrumentations are released on their own we cannot have a
fixed required version on this side.
While at it add vertexai to the list of excluded packages since:
- it has not been released yet
- the name is already claimed by openllmetry

* Regenerate bootstrap_gen

* Please spellcheck

---------

Co-authored-by: Leighton Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bootstrap_gen generation not handling genai instrumentation correctly

5 participants