Loosen opentelemetry-instrumentation-starlette[instruments] specifier
#3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
starlette-fix
branch
from
4b7f36b to
f10e156
Compare
aabmass
commented
Feb 26, 2025
instrumentation/opentelemetry-instrumentation-starlette/pyproject.toml
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Feb 27, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
I think we should add a test requirements with latest starlette too
Member
Author
Ya probably, I'll add to this PR. We really need a better way to do this long term I think. |
aabmass
force-pushed
the
starlette-fix
branch
from
f10e156 to
0e7d6c9
Compare
Member
Author
|
So I was able to generate locked dependencies for oldest and newest versions pretty easily with This works pretty nicely, I think we should adopt this for all packages. |
xrmx
approved these changes
Feb 28, 2025
xrmx
requested changes
Feb 28, 2025
instrumentation/opentelemetry-instrumentation-starlette/test-requirements.latest.txt
Outdated
Show resolved
Hide resolved
Kludex
reviewed
Feb 28, 2025
instrumentation/opentelemetry-instrumentation-starlette/test-requirements.latest.txt
Show resolved
Hide resolved
...entelemetry-instrumentation-starlette/src/opentelemetry/instrumentation/starlette/package.py
Show resolved
Hide resolved
xrmx
approved these changes
Mar 3, 2025
Contributor
|
@aabmass need to update the branch rules settings with the newer jobs names |
Member
Author
emdneto
approved these changes
Mar 3, 2025
9 tasks
github-project-automation
bot
moved this from Easy to review / merge / close
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3300
Ran
uv sync --upgradeto regenerate the lockfile with latest starlette.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I haven't actually tested this. Hoping @Kludex can confirm if this should be working.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.