Implement uninstrument for opentelemetry-instrumentation-vertexai
#3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
github-actions
bot
requested review from
alizenhom,
codefromthecrypt,
gyliu513,
karthikscale3,
lmolkova,
lzchen and
nirga
aabmass
force-pushed
the
vertex-uninstrument
branch
3 times, most recently
from
f5bff0b to
96de1c2
Compare
aabmass
changed the title
opentelemetry-insturmentation-vertexaiopentelemetry-instrumentation-vertexai
aabmass
force-pushed
the
vertex-uninstrument
branch
2 times, most recently
from
3779b90 to
4397344
Compare
xrmx
reviewed
Mar 5, 2025
...pentelemetry-instrumentation-vertexai/src/opentelemetry/instrumentation/vertexai/__init__.py
Show resolved
Hide resolved
aabmass
force-pushed
the
vertex-uninstrument
branch
from
4397344 to
af27dc9
Compare
xrmx
reviewed
Mar 6, 2025
instrumentation-genai/opentelemetry-instrumentation-vertexai/tests/test_instrumentor.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Mar 6, 2025
aabmass
force-pushed
the
vertex-uninstrument
branch
from
af27dc9 to
4c99954
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
_uninstrument()and adds some tests.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.