Skip to content

Conversation

@andremm
Copy link
Contributor

@andremm andremm commented Apr 9, 2025

Description

There's one instrumentation example inside tornado that doesn't run. This PR fixes the example, so it runs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  1. Clone contrib repo: git clone https://github.com/open-telemetry/opentelemetry-python-contrib
  2. Clone OTel Python repo: git clone https://github.com/open-telemetry/opentelemetry-python
  3. Access the contrib repo: cd opentelemetry-python-contrib
  4. Create a virtual env: python3 -m venv otelvenv
  5. Activate the virtual env: source otelvenv/bin/activate
  6. Install common dependencies:
pip install opentelemetry-distro/ opentelemetry-instrumentation/ \
 ../opentelemetry-python/opentelemetry-semantic-conventions/ \
 ../opentelemetry-python/opentelemetry-api/ \
 ../opentelemetry-python/opentelemetry-sdk/ \
 ../opentelemetry-python/opentelemetry-proto/ \
 ../opentelemetry-python/exporter/opentelemetry-exporter-otlp-proto-common
  1. Install tornado specific requirements:
pip install -r instrumentation/opentelemetry-instrumentation-tornado/test-requirements.txt
  1. Copy the instrumentation examples inside the instrumentation main __init__.py file into different Python files and try to run them.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@github-actions github-actions bot requested a review from shalevr April 9, 2025 16:48
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 10, 2025
@xrmx xrmx moved this to Easy to review / merge / close in @xrmx's Python PR digest Apr 10, 2025
@xrmx xrmx enabled auto-merge (squash) April 14, 2025 14:49
@xrmx xrmx merged commit 7562ff0 into open-telemetry:main Apr 14, 2025
720 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Apr 14, 2025
@andremm andremm deleted the tornado-snippet branch May 5, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants