refactor: botocore spans #3561
Open
refactor: botocore spans #3561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
unsure what is going on what the tox tests and versioning. could someone help guide me? |
xrmx
requested changes
Jun 5, 2025
| _DynamoDbExtension, | ||
| ) | ||
| from opentelemetry.semconv.trace import SpanAttributes | ||
| from opentelemetry.semconv._incubating.attributes.aws_attributes import ( |
Contributor
There was a problem hiding this comment.
Since these are a lot maybe just import aws_attributes and reference them as aws_attributes.AWS_DYNAMO_WHATEVER?
Comment on lines
-122
to
+116
| span.attributes[SpanAttributes.MESSAGING_DESTINATION], | ||
| span.attributes[MESSAGING_DESTINATION_NAME], |
Contributor
Author
There was a problem hiding this comment.
I cannot find the original SpanAttributes.MESSAGING_DESTINATION.
Contributor
There was a problem hiding this comment.
Then don't update it and keep the current one
Contributor
There was a problem hiding this comment.
| ) | ||
|
|
||
| span = self.assert_span(f"{self.topic_name} send") | ||
| self.assertEqual( |
EzzioMoreira
reviewed
Aug 8, 2025
| self.assertEqual( | ||
| "phone_number:**", | ||
| span.attributes[SpanAttributes.MESSAGING_DESTINATION], | ||
| span.attributes[MESSAGING_DESTINATION_NAME], |
Contributor
There was a problem hiding this comment.
The sames here. You should keep SpanAttributes....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.