optimization of remove_url_credentials __init__.py #3603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed second call of urlparse in remove_url_credentials
The committers listed above are authorized under a signed CLA. |
Contributor
|
I think this will be already taken care of in another pr: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3508/files#diff-9f93b3514e50dc2c60507d1deb1ad7bd80b8dcca02a5d1cb4bcec412b5cdcbaeR168 |
Author
indeed. I'll close this pr then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed second call of urlparse in remove_url_credentials
Description
There was a second call of urlparse thad did apparently nothing new compared to first urlparse. The call is removed
Fixes # (issue)
Type of change
How Has This Been Tested?
pytest
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.