AWS X-Ray Remote Sampler Part 2 - Add Rules Caching, Rules Matching Logic, Rate Limiter, and Sampling Targets Poller #3761
+2,498
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Oct 10, 2025
|
|
||
| ### Added | ||
|
|
||
| - `opentelemetry-sdk-extension-aws` Add caching, matching, and targets logic to complete AWS X-Ray Remote Sampler implementation |
There was a problem hiding this comment.
opentelemetry-sdk-extension-aws is released on its own and it has its own changelog in sdk-extension/opentelemetry-sdk-extension-aws
xrmx
reviewed
Oct 10, 2025
There was a problem hiding this comment.
Could you please add the following and take care of any eventual output of tox -e typecheck?
diff --git a/pyproject.toml b/pyproject.toml
index 30ada5bb2..45b8ea632 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -206,6 +206,7 @@ include = [
"instrumentation-genai/opentelemetry-instrumentation-weaviate",
"util/opentelemetry-util-genai",
"exporter/opentelemetry-exporter-credential-provider-gcp",
+ "sdk-extension/opentelemetry-sdk-extension-aws/src/opentelemetry/sdk/extension/aws/trace/sampler",
]
# We should also add type hints to the test suite - It helps on finding bugs.
# We are excluding for now because it's easier, and more important to add to the instrumentation packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
RuleCache_SamplingRuleAppliers, ordered by rule priority then rule name. Each Rule Applier corresponds to the Sampling Rule from GetSamplingRules. Each call to GetSamplingRules will only update theRules that have changed properties, to preserve the state of unchanged rules. This means Reservoir and Statistics will persist in Rules for unchanged rules._SamplingRuleApplier._SamplingRuleApplierwill sample the requests.GetSamplingTargetscall to determine the next target_SamplingRuleApplierto perform Fixed Rate & Reservoir Sampling, and to include a method to apply matching logic against a set of {resource, attributes} by using the wild card and attribute matching from Utils_RateLimitingSampler(applied before the fixed rate sampler) to be used in each rule applier.FallbackSampler, a combination of_RateLimitingSamplerandTraceIdRatioBasedsamplers to sample1 req/secand5%of additional requests in that second._InternalAwsXRayRemoteSamplerto depend onRuleCacheand aFallbackSamplerSampler for making sampling decisionsFixes #3305 -- This is the final PR to support X-Ray Remote Sampling.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.