Conformity of client interceptor(s) with the official grpc.*ClientInterceptor-interfaces #3877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceptor-interfaces Signed-off-by: Jason Parraga <[email protected]>
Signed-off-by: Jason Parraga <[email protected]>
|
This is really no longer needed to fix the issue for PubSub on GCP, since they released specific properties to instrument their software with OpenTelemetry: https://cloud.google.com/pubsub/docs/open-telemetry-tracing But it helps to add manual intercepts to gRPC clients |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a rebased version of PR #3384 that aims to update the OpenTelemetryClientInterceptor to support official gRPC client interceptor interfaces introduced in gRPC v1.8.0.
Changes
Test plan
Tested locally, working with grpc client instrumentation, also working with PubSub consuming and publishing
Related Issues
🤖 Generated with Claude Code