Skip to content

Commit 0c1aadf

Browse files
committed
Fix lint issue. Add comment
1 parent 75aacde commit 0c1aadf

File tree

2 files changed

+2
-1
lines changed
  • exporter/opentelemetry-exporter-otlp-proto-common

2 files changed

+2
-1
lines changed

exporter/opentelemetry-exporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ def filter(self, record):
6363
if current_log != getattr(self, "last_log", None):
6464
self.last_log = current_log
6565
return True
66+
# False means python's `logging` module will no longer process this log.
6667
return False
6768

6869

exporter/opentelemetry-exporter-otlp-proto-common/tests/test_common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88

99
class TestCommonFuncs(unittest.TestCase):
10-
def test_duplicate_logs_filter_Works(self):
10+
def test_duplicate_logs_filter_works(self):
1111
test_logger = logging.getLogger("testLogger")
1212
test_logger.addFilter(DuplicateFilter())
1313
with self.assertLogs("testLogger") as cm:

0 commit comments

Comments
 (0)