Skip to content

Commit 103f285

Browse files
committed
Fix api tests for real
1 parent c595be1 commit 103f285

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

opentelemetry-api/tests/metrics/test_meter.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class TestMeter(TestCase):
8585
# TODO: convert to assertNoLogs instead of mocking logger when 3.10 is baseline
8686
@patch("opentelemetry.metrics._internal._logger")
8787
def test_repeated_instrument_names(self, logger_mock):
88-
with self.assertNotRaises(Exception):
88+
try:
8989
test_meter = NoOpMeter("name")
9090

9191
test_meter.create_counter("counter")
@@ -97,6 +97,8 @@ def test_repeated_instrument_names(self, logger_mock):
9797
test_meter.create_observable_up_down_counter(
9898
"observable_up_down_counter", Mock()
9999
)
100+
except Exception as error: # pylint: disable=broad-exception-caught
101+
self.fail(f"Unexpected exception raised {error}")
100102

101103
for instrument_name in [
102104
"counter",
@@ -118,7 +120,7 @@ def test_repeated_instrument_names(self, logger_mock):
118120
logger_mock.warning.assert_not_called()
119121

120122
def test_repeated_instrument_names_with_different_advisory(self):
121-
with self.assertNotRaises(Exception):
123+
try:
122124
test_meter = NoOpMeter("name")
123125

124126
test_meter.create_counter("counter")
@@ -130,6 +132,8 @@ def test_repeated_instrument_names_with_different_advisory(self):
130132
test_meter.create_observable_up_down_counter(
131133
"observable_up_down_counter", Mock()
132134
)
135+
except Exception as error: # pylint: disable=broad-exception-caught
136+
self.fail(f"Unexpected exception raised {error}")
133137

134138
for instrument_name in [
135139
"counter",

0 commit comments

Comments
 (0)