Add setting of path function for plugins

Author: ocelotl

_file_configuration/src/opentelemetry/file_configuration/_internal/__init__.py

@@ -53,6 +53,17 @@
     "number": float,
 }
 
+_path_function = path_function
+
+
+def get_path_function() -> dict:
+    return _path_function
+
+
+def set_path_function(path_function: dict) -> None:
+    global _path_function
+    _path_function = path_function
+
 
 class FileConfigurationPlugin(ABC):
 
@@ -77,6 +88,13 @@ def function(*args, **kwargs) -> object:
         The function that will instantiate the plugin object.
         """
 
+    @property
+    def recursive_path(self) -> list:
+        """
+        The recursive path for the plugin object if any.
+        """
+        return []
+
 
 class SometimesMondaysOnSampler(Sampler):
     """
@@ -106,12 +124,13 @@ def get_description(self) -> str:
 class SometimesMondaysOnSamplerPlugin(FileConfigurationPlugin):
 
     @property
-    def schema(self) -> dict:
+    def schema(self) -> tuple:
         """
         Returns the plugin schema.
         """
-        return {
-            "sometimes_mondays_on": {
+        return (
+            "sometimes_mondays_on",
+            {
                 "type": "object",
                 "additionalProperties": False,
                 "properties": {
@@ -120,7 +139,7 @@ def schema(self) -> dict:
                     },
                 }
             }
-        }
+        )
 
     @property
     def schema_path(self) -> list:
@@ -148,34 +167,54 @@ def resolve_schema(json_file_path) -> dict:
     root_path = json_file_path.absolute()
 
     with open(json_file_path, "r") as json_file:
-        dictionary = jsonref_loads(
+        resolved_schema = jsonref_loads(
             json_file.read(), base_uri=root_path.as_uri()
         )
 
     for entry_point in entry_points(group="opentelemetry_file_configuration"):
 
         plugin = entry_point.load()()
 
-        sub_dictionary = dictionary
+        sub_resolved_schema = resolved_schema
 
         schema_path = []
 
         for schema_path_part in plugin.schema_path:
             schema_path.append(schema_path_part)
             try:
-                sub_dictionary = sub_dictionary[schema_path_part]
+                sub_resolved_schema = sub_resolved_schema[schema_path_part]
             except KeyError:
                 _logger.warning(
-                    "Unable to add plugin %s to schema: wrong path %s",
+                    "Unable to add plugin %s to schema: wrong schema path %s",
                     entry_point.name,
                     ",".join(schema_path)
                 )
                 break
         else:
-            for key, value in plugin.schema.items():
-                sub_dictionary[key] = value
+            sub_resolved_schema[plugin.schema[0]] = plugin.schema[1]
 
-    return dictionary
+        original_path_function = get_path_function()
+        sub_path_function = original_path_function
+
+        for schema_path_part in plugin.schema_path:
+
+            if schema_path_part == "properties":
+                continue
+
+            sub_path_function = (
+                sub_path_function[schema_path_part]["children"]
+            )
+
+        sub_path_function[plugin.schema[0]] = {}
+        sub_path_function[plugin.schema[0]]["function"] = plugin.function
+        sub_path_function[plugin.schema[0]]["children"] = {}
+        sub_path_function[plugin.schema[0]]["recursive_path"] = (
+            plugin.recursive_path
+        )
+
+    set_path_function(original_path_function)
+
+    return resolved_schema
 
 
 def load_file_configuration(file_configuration_file_path: str) -> dict:
@@ -231,15 +270,15 @@ def traverse(
 
             for positional_attribute in positional_attributes:
 
-                result_positional_attributes[positional_attribute] = str(
+                result_positional_attributes[positional_attribute] = (
                     _type_type[
                         schema_properties[positional_attribute]["type"]
                     ].__name__
                 )
 
             for optional_attribute in optional_attributes:
 
-                result_optional_attributes[optional_attribute] = str(
+                result_optional_attributes[optional_attribute] = (
                     _type_type[
                         schema_properties[optional_attribute]["type"]
                     ].__name__
@@ -477,6 +516,8 @@ def create_object(
             *positional_arguments, **optional_arguments
         )
 
+    path_function = get_path_function()
+
     result = create_object(
         file_configuration[object_name],
         processed_schema[object_name],

_file_configuration/tests/test_file_configuration.py

@@ -29,7 +29,9 @@
     substitute_environment_variables,
     validate_file_configuration,
 )
-from opentelemetry.file_configuration._internal.path_function import set_resource
+from opentelemetry.file_configuration._internal.path_function import (
+    set_resource,
+)
 
 set_trace
 
@@ -210,3 +212,14 @@ def test_plugin():
         ["probability"]
         ["type"]
     ) == "number"
+
+    processed_schema = process_schema(resolved_schema)
+
+    set_resource(
+        create_object(file_configuration, processed_schema, "resource")
+    )
+
+    tracer_provider = create_object(
+        file_configuration, processed_schema, "tracer_provider"
+    )
+    assert tracer_provider.sampler.sometimes_mondays_on._probability == 0.8