Feedback

Author: xrmx

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

@@ -338,7 +338,7 @@ def dropped_attributes(self) -> int:
         return 0
 
     @classmethod
-    def from_api_log_record(cls, record: APILogRecord) -> LogRecord:
+    def _from_api_log_record(cls, record: APILogRecord) -> LogRecord:
         return cls(
             timestamp=record.timestamp,
             observed_timestamp=record.observed_timestamp,
@@ -701,7 +701,8 @@ def emit(self, record: LogRecord | APILogRecord):
         and instrumentation info.
         """
         if isinstance(record, APILogRecord):
-            record = LogRecord.from_api_log_record(record)
+            record = LogRecord._from_api_log_record(record)
+            record.resource = self._resource
         log_data = LogData(record, self._instrumentation_scope)
         self._multi_log_record_processor.on_emit(log_data)
 

opentelemetry-sdk/tests/logs/test_log_record.py

@@ -199,7 +199,7 @@ def test_log_record_from_api_log_record(self):
             event_name="an.event",
         )
 
-        record = LogRecord.from_api_log_record(api_log_record)
+        record = LogRecord._from_api_log_record(api_log_record)
 
         self.assertEqual(record.timestamp, 1)
         self.assertEqual(record.observed_timestamp, 2)