Skip to content

Commit 1d62571

Browse files
committed
opentelemetry-sdk: fixup some pyright warnings
And then remove a bunch of dirs from the exclude list.
1 parent e75b0ab commit 1d62571

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,18 +72,21 @@ def export(
7272
Returns:
7373
The result of the export
7474
"""
75+
...
7576

7677
def shutdown(self) -> None:
7778
"""Shuts down the exporter.
7879
7980
Called when the SDK is shut down.
8081
"""
82+
...
8183

8284
def force_flush(self, timeout_millis: int = 30000) -> bool:
8385
"""Hint to ensure that the export of any spans the exporter has received
8486
prior to the call to ForceFlush SHOULD be completed as soon as possible, preferably
8587
before returning from this method.
8688
"""
89+
...
8790

8891

8992
class SimpleSpanProcessor(SpanProcessor):
@@ -102,7 +105,7 @@ def on_start(
102105
pass
103106

104107
def on_end(self, span: ReadableSpan) -> None:
105-
if not span.context.trace_flags.sampled:
108+
if span.context and not span.context.trace_flags.sampled:
106109
return
107110
token = attach(set_value(_SUPPRESS_INSTRUMENTATION_KEY, True))
108111
try:
@@ -188,7 +191,7 @@ def on_start(
188191
pass
189192

190193
def on_end(self, span: ReadableSpan) -> None:
191-
if not span.context.trace_flags.sampled:
194+
if span.context and not span.context.trace_flags.sampled:
192195
return
193196
self._batch_processor.emit(span)
194197

pyproject.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,8 @@ exclude = [
111111
"opentelemetry-sdk/tests",
112112
"opentelemetry-sdk/src/opentelemetry/sdk/_events",
113113
"opentelemetry-sdk/src/opentelemetry/sdk/_logs",
114-
"opentelemetry-sdk/src/opentelemetry/sdk/error_handler",
115114
"opentelemetry-sdk/src/opentelemetry/sdk/metrics",
116-
"opentelemetry-sdk/src/opentelemetry/sdk/trace/export",
117115
"opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py",
118-
"opentelemetry-sdk/src/opentelemetry/sdk/util",
119116
"opentelemetry-sdk/benchmarks",
120117
]
121118

0 commit comments

Comments
 (0)