Make explicit boundaries float only

Author: xrmx

docs/examples/metrics/instruments/example.py

@@ -62,7 +62,7 @@ def observable_gauge_func(options: CallbackOptions) -> Iterable[Observation]:
 # Histogram with explicit_bucket_boundaries advisory
 histogram = meter.create_histogram(
     "histogram_with_advisory",
-    advisory={"explicit_bucket_boundaries": [0, 1, 2]},
+    advisory={"explicit_bucket_boundaries": [0.0, 1.0, 2.0]},
 )
 histogram.record(99.9)
 

opentelemetry-api/src/opentelemetry/util/types.py

@@ -58,4 +58,4 @@
 
 
 class MetricsInstrumentAdvisory(TypedDict):
-    explicit_bucket_boundaries: Optional[Union[Sequence[int], Sequence[float]]]
+    explicit_bucket_boundaries: Optional[Sequence[float]]

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py

@@ -223,7 +223,7 @@ def create_histogram(
                 boundaries = advisory["explicit_bucket_boundaries"]
                 invalid_advisory = not (
                     boundaries
-                    and all(isinstance(e, (int, float)) for e in boundaries)
+                    and all(isinstance(e, float) for e in boundaries)
                 )
             except (KeyError, TypeError):
                 invalid_advisory = True

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py

@@ -29,7 +29,6 @@
     Sequence,
     Type,
     TypeVar,
-    Union,
 )
 
 from opentelemetry.metrics import (
@@ -472,14 +471,13 @@ def __init__(
         instrument_aggregation_temporality: AggregationTemporality,
         start_time_unix_nano: int,
         reservoir_builder: ExemplarReservoirBuilder,
-        boundaries: Optional[Union[Sequence[float], Sequence[int]]] = None,
+        boundaries: Optional[Sequence[float]] = None,
         record_min_max: bool = True,
     ):
         if boundaries is None:
             boundaries = (
                 _DEFAULT_EXPLICIT_BUCKET_HISTOGRAM_AGGREGATION_BOUNDARIES
             )
-
         super().__init__(
             attributes,
             reservoir_builder=partial(
@@ -1285,7 +1283,7 @@ def _create_aggregation(
             )
 
         if isinstance(instrument, Histogram):
-            boundaries: Optional[Union[Sequence[float], Sequence[int]]] = (
+            boundaries: Optional[Sequence[float]] = (
                 instrument._advisory.get("explicit_bucket_boundaries")
                 if instrument._advisory is not None
                 else None
@@ -1370,7 +1368,7 @@ class ExplicitBucketHistogramAggregation(Aggregation):
 
     def __init__(
         self,
-        boundaries: Optional[Union[Sequence[float], Sequence[int]]] = None,
+        boundaries: Optional[Sequence[float]] = None,
         record_min_max: bool = True,
     ) -> None:
         if boundaries is None:

opentelemetry-sdk/tests/metrics/integration_test/test_histogram_advisory_explicit_buckets.py

@@ -30,7 +30,8 @@ def test_default(self):
         )
         meter = meter_provider.get_meter("testmeter")
         histogram = meter.create_histogram(
-            "testhistogram", advisory={"explicit_bucket_boundaries": [1, 2, 3]}
+            "testhistogram",
+            advisory={"explicit_bucket_boundaries": [1.0, 2.0, 3.0]},
         )
         histogram.record(1, {"label": "value"})
         histogram.record(2, {"label": "value"})
@@ -44,7 +45,9 @@ def test_default(self):
         )
         metric = metrics.resource_metrics[0].scope_metrics[0].metrics[0]
         self.assertEqual(metric.name, "testhistogram")
-        self.assertEqual(metric.data.data_points[0].explicit_bounds, (1, 2, 3))
+        self.assertEqual(
+            metric.data.data_points[0].explicit_bounds, (1.0, 2.0, 3.0)
+        )
 
     def test_view_default_aggregation(self):
         reader = InMemoryMetricReader()
@@ -55,7 +58,8 @@ def test_view_default_aggregation(self):
         )
         meter = meter_provider.get_meter("testmeter")
         histogram = meter.create_histogram(
-            "testhistogram", advisory={"explicit_bucket_boundaries": [1, 2, 3]}
+            "testhistogram",
+            advisory={"explicit_bucket_boundaries": [1.0, 2.0, 3.0]},
         )
         histogram.record(1, {"label": "value"})
         histogram.record(2, {"label": "value"})
@@ -69,14 +73,16 @@ def test_view_default_aggregation(self):
         )
         metric = metrics.resource_metrics[0].scope_metrics[0].metrics[0]
         self.assertEqual(metric.name, "testhistogram")
-        self.assertEqual(metric.data.data_points[0].explicit_bounds, (1, 2, 3))
+        self.assertEqual(
+            metric.data.data_points[0].explicit_bounds, (1.0, 2.0, 3.0)
+        )
 
     def test_view_overrides_buckets(self):
         reader = InMemoryMetricReader()
         view = View(
             instrument_name="testhistogram",
             aggregation=ExplicitBucketHistogramAggregation(
-                boundaries=[10, 100, 1000]
+                boundaries=[10.0, 100.0, 1000.0]
             ),
         )
         meter_provider = MeterProvider(
@@ -85,7 +91,8 @@ def test_view_overrides_buckets(self):
         )
         meter = meter_provider.get_meter("testmeter")
         histogram = meter.create_histogram(
-            "testhistogram", advisory={"explicit_bucket_boundaries": [1, 2, 3]}
+            "testhistogram",
+            advisory={"explicit_bucket_boundaries": [1.0, 2.0, 3.0]},
         )
         histogram.record(1, {"label": "value"})
         histogram.record(2, {"label": "value"})
@@ -100,5 +107,5 @@ def test_view_overrides_buckets(self):
         metric = metrics.resource_metrics[0].scope_metrics[0].metrics[0]
         self.assertEqual(metric.name, "testhistogram")
         self.assertEqual(
-            metric.data.data_points[0].explicit_bounds, (10, 100, 1000)
+            metric.data.data_points[0].explicit_bounds, (10.0, 100.0, 1000.0)
         )

opentelemetry-sdk/tests/metrics/test_metrics.py

@@ -542,13 +542,14 @@ def test_create_histogram_with_advisory(self):
             "name",
             unit="unit",
             description="description",
-            advisory={"explicit_bucket_boundaries": [0, 1, 2]},
+            advisory={"explicit_bucket_boundaries": [0.0, 1.0, 2.0]},
         )
 
         self.assertIsInstance(histogram, Histogram)
         self.assertEqual(histogram.name, "name")
         self.assertEqual(
-            histogram._advisory, {"explicit_bucket_boundaries": [0, 1, 2]}
+            histogram._advisory,
+            {"explicit_bucket_boundaries": [0.0, 1.0, 2.0]},
         )
 
     def test_create_histogram_advisory_validation(self):
@@ -557,7 +558,8 @@ def test_create_histogram_advisory_validation(self):
             {"explicit_bucket_boundaries": []},
             {},
             [],
-            {"explicit_bucket_boundaries": [1, 2.0, "3"]},
+            {"explicit_bucket_boundaries": [1]},
+            {"explicit_bucket_boundaries": ["1"]},
         ]
         for advisory in advisories:
             with self.subTest(advisory=advisory):