Add tests.. Fix tox.ini ?

Author: DylanRussell

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py

@@ -196,6 +196,11 @@ def _get_credentials(
             )
         if isinstance(maybe_channel_creds, ChannelCredentials):
             return maybe_channel_creds
+        else:
+            raise RuntimeError(
+                f"Requested component '{credential_env}' is of type {type(maybe_channel_creds)}"
+                f" must be of type `grpc.ChannelCredentials`."
+            )
 
     certificate_file = environ.get(certificate_file_env_key)
     if certificate_file:

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py

@@ -294,7 +294,7 @@ def test_otlp_exporter_otlp_compression_unspecified(
     def test_that_credential_gets_passed_to_exporter(self, mock_entry_points):
         credential = ChannelCredentials(None)
 
-        def f(_):
+        def f():
             return credential
 
         mock_entry_points.configure_mock(
@@ -304,6 +304,29 @@ def f(_):
         # pylint: disable=protected-access
         assert exporter._credentials is credential
 
+    @patch.dict(
+        "os.environ",
+        {OTEL_PYTHON_EXPORTER_OTLP_CREDENTIAL_PROVIDER: "credential_provider"},
+    )
+    def test_that_missing_entry_point_raises_exception(self):
+        with self.assertRaises(RuntimeError):
+            OTLPSpanExporterForTesting(insecure=False)
+
+    @patch.dict(
+        "os.environ",
+        {OTEL_PYTHON_EXPORTER_OTLP_CREDENTIAL_PROVIDER: "credential_provider"},
+    )
+    @patch("opentelemetry.exporter.otlp.proto.grpc.exporter.entry_points")
+    def test_that_entry_point_returning_bad_type_raises_exception(self, mock_entry_points):
+        def f():
+            return 1
+
+        mock_entry_points.configure_mock(
+            return_value=[IterEntryPoint("custom_credential", f)]
+        )
+        with self.assertRaises(RuntimeError):
+            OTLPSpanExporterForTesting(insecure=False)
+
     # pylint: disable=no-self-use, disable=unused-argument
     @patch(
         "opentelemetry.exporter.otlp.proto.grpc.exporter.ssl_channel_credentials"

exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py

@@ -61,4 +61,9 @@ def _load_session_from_envvar(
             )
         if isinstance(maybe_session, requests.Session):
             return maybe_session
+        else:
+            raise RuntimeError(
+                f"Requested component '{credential_env}' is of type {type(maybe_session)}"
+                f" must be of type `requests.Session`."
+            )
     return None

exporter/opentelemetry-exporter-otlp-proto-http/tests/metrics/test_otlp_metrics_exporter.py

@@ -163,7 +163,7 @@ def test_constructor_default(self):
     def test_exporter_metrics_env_take_priority(self, mock_entry_points):
         credential = Session()
 
-        def f(_):
+        def f():
             return credential
 
         mock_entry_points.configure_mock(

exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_log_exporter.py

@@ -126,7 +126,7 @@ def test_constructor_default(self):
     def test_exporter_logs_env_take_priority(self, mock_entry_points):
         credential = Session()
 
-        def f(_):
+        def f():
             return credential
 
         mock_entry_points.configure_mock(
@@ -162,6 +162,23 @@ def f(_):
             "application/x-protobuf",
         )
 
+
+    @patch.dict(
+        "os.environ",
+        {
+            OTEL_PYTHON_EXPORTER_OTLP_LOGS_CREDENTIAL_PROVIDER: "provider_without_entry_point",
+        },
+    )
+    @patch("opentelemetry.exporter.otlp.proto.http._common.entry_points")
+    def test_exception_raised_when_entrypoint_returns_wrong_type(self, mock_entry_points):
+        def f():
+            return 1
+        mock_entry_points.configure_mock(
+            return_value=[IterEntryPoint("custom_credential", f)]
+        )
+        with self.assertRaises(RuntimeError):
+            OTLPLogExporter()
+
     @patch.dict(
         "os.environ",
         {

exporter/opentelemetry-exporter-otlp-proto-http/tests/test_proto_span_exporter.py

@@ -120,7 +120,7 @@ def test_constructor_default(self):
     def test_exporter_traces_env_take_priority(self, mock_entry_point):
         credential = Session()
 
-        def f(_):
+        def f():
             return credential
 
         mock_entry_point.configure_mock(

tox.ini

@@ -153,7 +153,7 @@ deps =
   getting-started: {env:CONTRIB_REPO}\#egg=opentelemetry-instrumentation-wsgi&subdirectory=instrumentation/opentelemetry-instrumentation-wsgi
   getting-started: {env:CONTRIB_REPO}\#egg=opentelemetry-instrumentation-flask&subdirectory=instrumentation/opentelemetry-instrumentation-flask
 
-allowlist_externals = sh
+allowlist_externals = sh, pytest
 
 setenv =
   ; override CONTRIB_REPO_SHA via env variable when testing other branches/commits than main