Respond to comments in PR

Author: DylanRussell

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py

@@ -172,6 +172,7 @@ def _export(self, batch_strategy: BatchExportStrategy) -> None:
     # See https://github.com/open-telemetry/opentelemetry-python/issues/4261
     def emit(self, data: Telemetry) -> None:
         if self._shutdown:
+            self._logger.info("shutdowing")
             return
         if self._pid != os.getpid():
             self._bsp_reset_once.do_once(self._at_fork_reinit)

opentelemetry-sdk/tests/logs/test_export.py

@@ -20,6 +20,8 @@
 from unittest.mock import Mock, patch
 
 from opentelemetry._logs import SeverityNumber
+from opentelemetry._logs import set_logger_provider
+
 from opentelemetry.sdk import trace
 from opentelemetry.sdk._logs import (
     LogData,
@@ -44,6 +46,7 @@
 from opentelemetry.sdk.util.instrumentation import InstrumentationScope
 from opentelemetry.trace import TraceFlags
 from opentelemetry.trace.span import INVALID_SPAN_CONTEXT
+from opentelemetry.sdk.resources import Resource
 
 EMPTY_LOG = LogData(
     log_record=LogRecord(),
@@ -342,6 +345,27 @@ def test_emit_call_log_record(self):
         logger.error("error")
         self.assertEqual(log_record_processor.emit.call_count, 1)
 
+    def test_logging_lib_not_invoked_in_batch_log_record_emit(self):
+        exporter = Mock()
+        processor = BatchLogRecordProcessor(exporter)
+        logger_provider = LoggerProvider(
+            resource=Resource.create(
+                {
+                    "service.name": "shoppingcart",
+                    "service.instance.id": "instance-12",
+                }
+            ),
+        )
+        logger_provider.add_log_record_processor(processor)
+        # Attach OTLP handler to root logger
+        logging.getLogger().addHandler(
+            LoggingHandler(level=logging.INFO, logger_provider=logger_provider)
+        )
+        # If `emit` calls logging.log then this test will throw a maximum recursion depth exceeded exception and fail.
+        processor.emit(EMPTY_LOG)
+        processor.shutdown()
+        processor.emit(EMPTY_LOG)
+
     def test_args(self):
         exporter = InMemoryLogExporter()
         log_record_processor = BatchLogRecordProcessor(

opentelemetry-sdk/tests/shared_internal/test_batch_processor.py

@@ -14,7 +14,6 @@
 
 # pylint: disable=protected-access
 import gc
-import logging
 import multiprocessing
 import os
 import time
@@ -28,11 +27,8 @@
 import pytest
 from pytest import mark
 
-from opentelemetry._logs import set_logger_provider
 from opentelemetry.sdk._logs import (
     LogData,
-    LoggerProvider,
-    LoggingHandler,
     LogRecord,
 )
 from opentelemetry.sdk._logs.export import (
@@ -214,29 +210,3 @@ def test_record_processor_is_garbage_collected(
 
         # Then the reference to the processor should no longer exist
         assert weak_ref() is None
-
-    def test_logging_lib_not_invoked_in_emit(
-        self, batch_processor_class, telemetry
-    ):
-        exporter = Mock()
-        processor = batch_processor_class(exporter)
-        processor._batch_processor.emit(telemetry)
-        logger_provider = LoggerProvider(
-            resource=Resource.create(
-                {
-                    "service.name": "shoppingcart",
-                    "service.instance.id": "instance-12",
-                }
-            ),
-        )
-        set_logger_provider(logger_provider)
-        logger_provider.add_log_record_processor(processor)
-        handler = LoggingHandler(
-            level=logging.INFO, logger_provider=logger_provider
-        )
-        # Attach OTLP handler to root logger
-        logging.getLogger().addHandler(handler)
-        # If `emit` calls logging.log then this test will throw a maximum recursion depth exceeded exception and fail.
-        processor.emit(telemetry)
-        processor.shutdown()
-        processor.emit(telemetry)