Skip to content

Commit 39022ee

Browse files
authored
Apply suggestions from code review
1 parent 60724fc commit 39022ee

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

opentelemetry-sdk/tests/logs/test_export.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ def test_emit_call_log_record(self):
350350
reason="assertNoLogs only exists in python 3.10+.",
351351
)
352352
def test_logging_lib_not_invoked_in_batch_log_record_emit(self): # pylint: disable=no-self-use
353+
# See https://github.com/open-telemetry/opentelemetry-python/issues/4261
353354
exporter = Mock()
354355
processor = BatchLogRecordProcessor(exporter)
355356
logger_provider = LoggerProvider(
@@ -375,9 +376,8 @@ def test_logging_lib_not_invoked_in_batch_log_record_emit(self): # pylint: disa
375376
with self.assertNoLogs(sdk_logger, logging.NOTSET):
376377
processor.emit(EMPTY_LOG)
377378
sdk_logger.removeHandler(handler)
378-
except Exception as exc:
379+
finally:
379380
sdk_logger.removeHandler(handler)
380-
raise exc
381381

382382
def test_args(self):
383383
exporter = InMemoryLogExporter()

0 commit comments

Comments
 (0)