Skip to content

Commit 3f1669e

Browse files
committed
Rename LogRecordProcessor.emit to on_emit
1 parent 59baf31 commit 3f1669e

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2323
([#4637](https://github.com/open-telemetry/opentelemetry-python/pull/4637))
2424
- Logging API accepts optional `context`; deprecates `trace_id`, `span_id`, `trace_flags`.
2525
([#4597](https://github.com/open-telemetry/opentelemetry-python/pull/4597))
26+
- Rename LogRecordProcessor.emit to on_emit
27+
([#](https://github.com/open-telemetry/opentelemetry-python/pull/))
2628

2729
## Version 1.34.0/0.55b0 (2025-06-04)
2830

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ class LogRecordProcessor(abc.ABC):
354354
"""
355355

356356
@abc.abstractmethod
357-
def emit(self, log_data: LogData):
357+
def on_emit(self, log_data: LogData):
358358
"""Emits the `LogData`"""
359359

360360
@abc.abstractmethod
@@ -398,9 +398,9 @@ def add_log_record_processor(
398398
with self._lock:
399399
self._log_record_processors += (log_record_processor,)
400400

401-
def emit(self, log_data: LogData) -> None:
401+
def on_emit(self, log_data: LogData) -> None:
402402
for lp in self._log_record_processors:
403-
lp.emit(log_data)
403+
lp.on_emit(log_data)
404404

405405
def shutdown(self) -> None:
406406
"""Shutdown the log processors one by one"""
@@ -472,8 +472,8 @@ def _submit_and_wait(
472472
for future in futures:
473473
future.result()
474474

475-
def emit(self, log_data: LogData):
476-
self._submit_and_wait(lambda lp: lp.emit, log_data)
475+
def on_emit(self, log_data: LogData):
476+
self._submit_and_wait(lambda lp: lp.on_emit, log_data)
477477

478478
def shutdown(self):
479479
self._submit_and_wait(lambda lp: lp.shutdown)

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ def __init__(self, exporter: LogExporter):
112112
self._exporter = exporter
113113
self._shutdown = False
114114

115-
def emit(self, log_data: LogData):
115+
def on_emit(self, log_data: LogData):
116116
if self._shutdown:
117117
_logger.warning("Processor is already shutdown, ignoring call")
118118
return
@@ -186,8 +186,8 @@ def __init__(
186186
"Log",
187187
)
188188

189-
def emit(self, log_data: LogData) -> None:
190-
return self._batch_processor.emit(log_data)
189+
def on_emit(self, log_data: LogData) -> None:
190+
return self._batch_processor.on_emit(log_data)
191191

192192
def shutdown(self):
193193
return self._batch_processor.shutdown()

0 commit comments

Comments
 (0)