Get rid of test that may deadlock and flushOnClose approach

Author: DylanRussell

opentelemetry-api/tests/logs/test_log_record.py

@@ -25,3 +25,7 @@ class TestLogRecord(unittest.TestCase):
     def test_log_record_observed_timestamp_default(self, time_ns_mock):  # type: ignore
         time_ns_mock.return_value = OBSERVED_TIMESTAMP
         self.assertEqual(LogRecord().observed_timestamp, OBSERVED_TIMESTAMP)
+    
+    def test_context_used_by_default(self):
+        record = LogRecord()
+        

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

@@ -551,7 +551,6 @@ def __init__(
     ) -> None:
         super().__init__(level=level)
         self._logger_provider = logger_provider or get_logger_provider()
-        # self.flushOnClose = False
 
     @staticmethod
     def _get_attributes(record: logging.LogRecord) -> _ExtendedAttributes:

opentelemetry-sdk/tests/logs/test_handler.py

@@ -62,33 +62,6 @@ def test_handler_custom_log_level(self):
             logger.critical("No Time For Caution")
         self.assertEqual(processor.emit_count(), 2)
 
-    def test_handler_calling_flush_does_not_cause_deadlock(self):  # pylint: disable=no-self-use
-        class LogProcessorThatAccessesLockOnFlush(LogRecordProcessor):
-            def on_emit(self, log_data: LogData):
-                pass
-
-            def shutdown(self):
-                pass
-
-            def force_flush(self, timeout_millis: int = 30000):
-                # Deadlock will happen here IF `flush` starts a new thread
-                # and then blocks, if it just starts a thread and then returns
-                # we don't seem to encounter the issue..
-                with logging._lock:  # pylint: disable=protected-access
-                    pass
-
-        logger_provider = LoggerProvider()
-        processor = LogProcessorThatAccessesLockOnFlush()
-        logger_provider.add_log_record_processor(processor)
-        handler = LoggingHandler(logger_provider=logger_provider)
-        logging.getLogger().addHandler(handler)
-        # The below code is essentially recreating what is causing the problem inside
-        # logging.config.dictConfig. Actually calling logging.config.dictConfig will modify
-        # global state inside the logging module and break lots of tests.
-        with logging._lock:  # pylint: disable=protected-access
-            for handler in logging.getLogger().handlers:
-                handler.flush()
-
     # pylint: disable=protected-access
     def test_log_record_emit_noop(self):
         noop_logger_provder = NoOpLoggerProvider()