Skip to content

Commit 49d402e

Browse files
committed
Explain why test is skipped
1 parent ec69083 commit 49d402e

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,10 @@ def test_export_over_closed_grpc_channel(self):
371371
str(err.exception), "Cannot invoke RPC on closed channel!"
372372
)
373373

374-
@unittest.skipIf(system() == "Windows", "Does not work in Windows")
374+
@unittest.skipIf(
375+
system() == "Windows",
376+
"For gRPC + windows there's some added delay in the RPCs which breaks the assertion over amount of time passed.",
377+
)
375378
def test_retry_info_is_respected(self):
376379
mock_trace_service = TraceServiceServicerWithExportParams(
377380
StatusCode.UNAVAILABLE,
@@ -392,7 +395,10 @@ def test_retry_info_is_respected(self):
392395
# 1 second plus wiggle room so the test passes consistently.
393396
self.assertAlmostEqual(after - before, 1, 1)
394397

395-
@unittest.skipIf(system() == "Windows", "Does not work in Windows")
398+
@unittest.skipIf(
399+
system() == "Windows",
400+
"For gRPC + windows there's some added delay in the RPCs which breaks the assertion over amount of time passed.",
401+
)
396402
def test_retry_not_made_if_would_exceed_timeout(self):
397403
mock_trace_service = TraceServiceServicerWithExportParams(
398404
StatusCode.UNAVAILABLE
@@ -414,7 +420,10 @@ def test_retry_not_made_if_would_exceed_timeout(self):
414420
# There's a +/-20% jitter on each backoff.
415421
self.assertTrue(2.35 < after - before < 3.65)
416422

417-
@unittest.skipIf(system() == "Windows", "Does not work in Windows")
423+
@unittest.skipIf(
424+
system() == "Windows",
425+
"For gRPC + windows there's some added delay in the RPCs which breaks the assertion over amount of time passed.",
426+
)
418427
def test_timeout_set_correctly(self):
419428
mock_trace_service = TraceServiceServicerWithExportParams(
420429
StatusCode.UNAVAILABLE, optional_export_sleep=0.25

0 commit comments

Comments
 (0)