Skip to content

Commit 4a3f4f9

Browse files
committed
found tox.ini updates, and searched for references of mypy.
1 parent f72a82d commit 4a3f4f9

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ You can run `tox` with the following arguments:
6464
- `tox -e public-symbols-check` to run public_symbols_checker.py.
6565
- `tox -e docker-tests-{otlpexporter,opencensus}` to run tests in both or either one location.
6666
- `tox -e tracecontext` to run integration tests for tracecontext.
67-
- `tox -d sphinx-build` to build html sphinx docs.
67+
- `tox -d shellcheck` to run a security check on the current shell.
6868

6969
`ruff check` and `ruff format` are executed when `tox -e ruff` is run. We strongly recommend you to configure [pre-commit](https://pre-commit.com/) locally to run `ruff` automatically before each commit by installing it as git hooks. You just need to [install pre-commit](https://pre-commit.com/#install) in your environment:
7070

scripts/proto_codegen.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ cd $repo_root/opentelemetry-proto/src
5555

5656
# clean up old generated code
5757
find opentelemetry/ -regex ".*_pb2.*\.pyi?" -exec rm {} +
58-
# unsure if we need to update this. I could not find the module referenced below in this repo. We would need to change this pyright.
5958
# generate proto code for all protos
6059
all_protos=$(find $PROTO_REPO_DIR/ -iname "*.proto")
6160
python -m grpc_tools.protoc \

tox.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ envlist =
9898

9999
[testenv]
100100
deps =
101-
lint: -r dev-requirements.txt # I think we should look into using something like pip-sync to keep this env inline with the requirements.txt.
101+
lint: -r dev-requirements.txt
102102
coverage: pytest
103103
coverage: pytest-cov
104104

@@ -228,7 +228,7 @@ commands =
228228
coverage: {toxinidir}/scripts/coverage.sh
229229

230230

231-
[testenv:sphinx-build] # there were 2 instances of this name (spellcheck), renaming to sphinx-build
231+
[testenv:spellcheck]
232232
basepython: python3
233233
recreate = True
234234
deps =

0 commit comments

Comments
 (0)