removing LogData and extending SDK LogRecord to have instrumentation scope

Author: hectorhdzg

CHANGELOG.md

@@ -37,6 +37,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#4620](https://github.com/open-telemetry/opentelemetry-python/pull/4620))
 - Set expected User-Agent in HTTP headers for grpc OTLP exporter
   ([#4658](https://github.com/open-telemetry/opentelemetry-python/pull/4658))
+- Remove LogData and extend SDK LogRecord to have instrumentation scope
+  ([#](https://github.com/open-telemetry/opentelemetry-python/pull/))
 
 ## Version 1.34.0/0.55b0 (2025-06-04)
 

exporter/opentelemetry-exporter-otlp-proto-common/src/opentelemetry/exporter/otlp/proto/common/_internal/_log_encoder/__init__.py

@@ -30,47 +30,47 @@
     ResourceLogs,
     ScopeLogs,
 )
-from opentelemetry.sdk._logs import LogData
+from opentelemetry.sdk._logs import LogRecord as SDKLogRecord
 
 
-def encode_logs(batch: Sequence[LogData]) -> ExportLogsServiceRequest:
+def encode_logs(batch: Sequence[SDKLogRecord]) -> ExportLogsServiceRequest:
     return ExportLogsServiceRequest(resource_logs=_encode_resource_logs(batch))
 
 
-def _encode_log(log_data: LogData) -> PB2LogRecord:
+def _encode_log(log_record: SDKLogRecord) -> PB2LogRecord:
     span_id = (
         None
-        if log_data.log_record.span_id == 0
-        else _encode_span_id(log_data.log_record.span_id)
+        if log_record.span_id == 0
+        else _encode_span_id(log_record.span_id)
     )
     trace_id = (
         None
-        if log_data.log_record.trace_id == 0
-        else _encode_trace_id(log_data.log_record.trace_id)
+        if log_record.trace_id == 0
+        else _encode_trace_id(log_record.trace_id)
     )
-    body = log_data.log_record.body
+    body = log_record.body
     return PB2LogRecord(
-        time_unix_nano=log_data.log_record.timestamp,
-        observed_time_unix_nano=log_data.log_record.observed_timestamp,
+        time_unix_nano=log_record.timestamp,
+        observed_time_unix_nano=log_record.observed_timestamp,
         span_id=span_id,
         trace_id=trace_id,
-        flags=int(log_data.log_record.trace_flags),
+        flags=int(log_record.trace_flags),
         body=_encode_value(body, allow_null=True),
-        severity_text=log_data.log_record.severity_text,
+        severity_text=log_record.severity_text,
         attributes=_encode_attributes(
-            log_data.log_record.attributes, allow_null=True
+            log_record.attributes, allow_null=True
         ),
-        dropped_attributes_count=log_data.log_record.dropped_attributes,
-        severity_number=log_data.log_record.severity_number.value,
-        event_name=log_data.log_record.event_name,
+        dropped_attributes_count=log_record.dropped_attributes,
+        severity_number=log_record.severity_number.value,
+        event_name=log_record.event_name,
     )
 
 
-def _encode_resource_logs(batch: Sequence[LogData]) -> List[ResourceLogs]:
+def _encode_resource_logs(batch: Sequence[SDKLogRecord]) -> List[ResourceLogs]:
     sdk_resource_logs = defaultdict(lambda: defaultdict(list))
 
     for sdk_log in batch:
-        sdk_resource = sdk_log.log_record.resource
+        sdk_resource = sdk_log.resource
         sdk_instrumentation = sdk_log.instrumentation_scope or None
         pb2_log = _encode_log(sdk_log)
 

exporter/opentelemetry-exporter-otlp-proto-common/tests/test_log_encoder.py

@@ -45,7 +45,7 @@
 from opentelemetry.proto.resource.v1.resource_pb2 import (
     Resource as PB2Resource,
 )
-from opentelemetry.sdk._logs import LogData, LogLimits
+from opentelemetry.sdk._logs import LogLimits
 from opentelemetry.sdk._logs import LogRecord as SDKLogRecord
 from opentelemetry.sdk.resources import Resource as SDKResource
 from opentelemetry.sdk.util.instrumentation import InstrumentationScope
@@ -88,7 +88,7 @@ def test_dropped_attributes_count(self):
         )
 
     @staticmethod
-    def _get_sdk_log_data() -> List[LogData]:
+    def _get_sdk_log_data() -> List[SDKLogRecord]:
         ctx_log1 = set_span_in_context(
             NonRecordingSpan(
                 SpanContext(
@@ -99,35 +99,31 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log1 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650195189786880,
-                observed_timestamp=1644650195189786881,
-                context=ctx_log1,
-                severity_text="WARN",
-                severity_number=SeverityNumber.WARN,
-                body="Do not go gentle into that good night. Rage, rage against the dying of the light",
-                resource=SDKResource(
-                    {"first_resource": "value"},
-                    "resource_schema_url",
-                ),
-                attributes={"a": 1, "b": "c"},
+        log1 = SDKLogRecord(
+            timestamp=1644650195189786880,
+            observed_timestamp=1644650195189786881,
+            context=ctx_log1,
+            severity_text="WARN",
+            severity_number=SeverityNumber.WARN,
+            body="Do not go gentle into that good night. Rage, rage against the dying of the light",
+            resource=SDKResource(
+                {"first_resource": "value"},
+                "resource_schema_url",
             ),
+            attributes={"a": 1, "b": "c"},
             instrumentation_scope=InstrumentationScope(
                 "first_name", "first_version"
             ),
         )
 
-        log2 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650249738562048,
-                observed_timestamp=1644650249738562049,
-                severity_text="WARN",
-                severity_number=SeverityNumber.WARN,
-                body="Cooper, this is no time for caution!",
-                resource=SDKResource({"second_resource": "CASE"}),
-                attributes={},
-            ),
+        log2 = SDKLogRecord(
+            timestamp=1644650249738562048,
+            observed_timestamp=1644650249738562049,
+            severity_text="WARN",
+            severity_number=SeverityNumber.WARN,
+            body="Cooper, this is no time for caution!",
+            resource=SDKResource({"second_resource": "CASE"}),
+            attributes={},
             instrumentation_scope=InstrumentationScope(
                 "second_name", "second_version"
             ),
@@ -143,17 +139,15 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log3 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650427658989056,
-                observed_timestamp=1644650427658989057,
-                context=ctx_log3,
-                severity_text="DEBUG",
-                severity_number=SeverityNumber.DEBUG,
-                body="To our galaxy",
-                resource=SDKResource({"second_resource": "CASE"}),
-                attributes={"a": 1, "b": "c"},
-            ),
+        log3 = SDKLogRecord(
+            timestamp=1644650427658989056,
+            observed_timestamp=1644650427658989057,
+            context=ctx_log3,
+            severity_text="DEBUG",
+            severity_number=SeverityNumber.DEBUG,
+            body="To our galaxy",
+            resource=SDKResource({"second_resource": "CASE"}),
+            attributes={"a": 1, "b": "c"},
             instrumentation_scope=None,
         )
 
@@ -167,20 +161,18 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log4 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650584292683008,
-                observed_timestamp=1644650584292683009,
-                context=ctx_log4,
-                severity_text="INFO",
-                severity_number=SeverityNumber.INFO,
-                body="Love is the one thing that transcends time and space",
-                resource=SDKResource(
-                    {"first_resource": "value"},
-                    "resource_schema_url",
-                ),
-                attributes={"filename": "model.py", "func_name": "run_method"},
+        log4 = SDKLogRecord(
+            timestamp=1644650584292683008,
+            observed_timestamp=1644650584292683009,
+            context=ctx_log4,
+            severity_text="INFO",
+            severity_number=SeverityNumber.INFO,
+            body="Love is the one thing that transcends time and space",
+            resource=SDKResource(
+                {"first_resource": "value"},
+                "resource_schema_url",
             ),
+            attributes={"filename": "model.py", "func_name": "run_method"},
             instrumentation_scope=InstrumentationScope(
                 "another_name", "another_version"
             ),
@@ -196,17 +188,15 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log5 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650584292683009,
-                observed_timestamp=1644650584292683010,
-                context=ctx_log5,
-                severity_text="INFO",
-                severity_number=SeverityNumber.INFO,
-                body={"error": None, "array_with_nones": [1, None, 2]},
-                resource=SDKResource({}),
-                attributes={},
-            ),
+        log5 = SDKLogRecord(
+            timestamp=1644650584292683009,
+            observed_timestamp=1644650584292683010,
+            context=ctx_log5,
+            severity_text="INFO",
+            severity_number=SeverityNumber.INFO,
+            body={"error": None, "array_with_nones": [1, None, 2]},
+            resource=SDKResource({}),
+            attributes={},
             instrumentation_scope=InstrumentationScope(
                 "last_name", "last_version"
             ),
@@ -222,20 +212,18 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log6 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650584292683022,
-                observed_timestamp=1644650584292683022,
-                context=ctx_log6,
-                severity_text="ERROR",
-                severity_number=SeverityNumber.ERROR,
-                body="This instrumentation scope has a schema url",
-                resource=SDKResource(
-                    {"first_resource": "value"},
-                    "resource_schema_url",
-                ),
-                attributes={"filename": "model.py", "func_name": "run_method"},
+        log6 = SDKLogRecord(
+            timestamp=1644650584292683022,
+            observed_timestamp=1644650584292683022,
+            context=ctx_log6,
+            severity_text="ERROR",
+            severity_number=SeverityNumber.ERROR,
+            body="This instrumentation scope has a schema url",
+            resource=SDKResource(
+                {"first_resource": "value"},
+                "resource_schema_url",
             ),
+            attributes={"filename": "model.py", "func_name": "run_method"},
             instrumentation_scope=InstrumentationScope(
                 "scope_with_url",
                 "scope_with_url_version",
@@ -253,20 +241,18 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log7 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650584292683033,
-                observed_timestamp=1644650584292683033,
-                context=ctx_log7,
-                severity_text="FATAL",
-                severity_number=SeverityNumber.FATAL,
-                body="This instrumentation scope has a schema url and attributes",
-                resource=SDKResource(
-                    {"first_resource": "value"},
-                    "resource_schema_url",
-                ),
-                attributes={"filename": "model.py", "func_name": "run_method"},
+        log7 = SDKLogRecord(
+            timestamp=1644650584292683033,
+            observed_timestamp=1644650584292683033,
+            context=ctx_log7,
+            severity_text="FATAL",
+            severity_number=SeverityNumber.FATAL,
+            body="This instrumentation scope has a schema url and attributes",
+            resource=SDKResource(
+                {"first_resource": "value"},
+                "resource_schema_url",
             ),
+            attributes={"filename": "model.py", "func_name": "run_method"},
             instrumentation_scope=InstrumentationScope(
                 "scope_with_attributes",
                 "scope_with_attributes_version",
@@ -285,21 +271,17 @@ def _get_sdk_log_data() -> List[LogData]:
                 )
             )
         )
-        log8 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650584292683044,
-                observed_timestamp=1644650584292683044,
-                context=ctx_log8,
-                severity_text="INFO",
-                severity_number=SeverityNumber.INFO,
-                body="Test export of extended attributes",
-                resource=SDKResource({}),
-                attributes={
-                    "extended": {
-                        "sequence": [{"inner": "mapping", "none": None}]
-                    }
-                },
-            ),
+        log8 = SDKLogRecord(
+            timestamp=1644650584292683044,
+            observed_timestamp=1644650584292683044,
+            context=ctx_log8,
+            severity_text="INFO",
+            severity_number=SeverityNumber.INFO,
+            body="Test export of extended attributes",
+            resource=SDKResource({}),
+            attributes={
+                "extended": {"sequence": [{"inner": "mapping", "none": None}]}
+            },
             instrumentation_scope=InstrumentationScope(
                 "extended_name", "extended_version"
             ),
@@ -601,7 +583,7 @@ def get_test_logs(
         return sdk_logs, pb2_service_request
 
     @staticmethod
-    def _get_test_logs_dropped_attributes() -> List[LogData]:
+    def _get_test_logs_dropped_attributes() -> List[SDKLogRecord]:
         ctx_log1 = set_span_in_context(
             NonRecordingSpan(
                 SpanContext(
@@ -612,34 +594,30 @@ def _get_test_logs_dropped_attributes() -> List[LogData]:
                 )
             )
         )
-        log1 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650195189786880,
-                context=ctx_log1,
-                severity_text="WARN",
-                severity_number=SeverityNumber.WARN,
-                body="Do not go gentle into that good night. Rage, rage against the dying of the light",
-                resource=SDKResource({"first_resource": "value"}),
-                attributes={"a": 1, "b": "c", "user_id": "B121092"},
-                limits=LogLimits(max_attributes=1),
-            ),
+        log1 = SDKLogRecord(
+            timestamp=1644650195189786880,
+            context=ctx_log1,
+            severity_text="WARN",
+            severity_number=SeverityNumber.WARN,
+            body="Do not go gentle into that good night. Rage, rage against the dying of the light",
+            resource=SDKResource({"first_resource": "value"}),
+            attributes={"a": 1, "b": "c", "user_id": "B121092"},
+            limits=LogLimits(max_attributes=1),
             instrumentation_scope=InstrumentationScope(
                 "first_name", "first_version"
             ),
         )
         ctx_log2 = set_span_in_context(
             NonRecordingSpan(SpanContext(0, 0, False))
         )
-        log2 = LogData(
-            log_record=SDKLogRecord(
-                timestamp=1644650249738562048,
-                context=ctx_log2,
-                severity_text="WARN",
-                severity_number=SeverityNumber.WARN,
-                body="Cooper, this is no time for caution!",
-                resource=SDKResource({"second_resource": "CASE"}),
-                attributes={},
-            ),
+        log2 = SDKLogRecord(
+            timestamp=1644650249738562048,
+            context=ctx_log2,
+            severity_text="WARN",
+            severity_number=SeverityNumber.WARN,
+            body="Cooper, this is no time for caution!",
+            resource=SDKResource({"second_resource": "CASE"}),
+            attributes={},
             instrumentation_scope=InstrumentationScope(
                 "second_name", "second_version"
             ),