Change set_attributes to take a Mapping

This currently specifies a Dict[str, types.AttributeValue], which is invariant in its value type. As a result, you cannot pass a dictionary with a narrower value type, e.g. a dict[str, str]. But this should be allowed, since set_attributes simply adds all key-value pairs in its argument, and all such pairs are valied. Using Mapping takes care of this issue, since it's covariant in its value type.

Author: camillol

opentelemetry-api/src/opentelemetry/trace/span.py

@@ -79,7 +79,7 @@ def get_span_context(self) -> "SpanContext":
 
     @abc.abstractmethod
     def set_attributes(
-        self, attributes: typing.Dict[str, types.AttributeValue]
+        self, attributes: typing.Mapping[str, types.AttributeValue]
     ) -> None:
         """Sets Attributes.
 
@@ -529,7 +529,7 @@ def end(self, end_time: typing.Optional[int] = None) -> None:
         pass
 
     def set_attributes(
-        self, attributes: typing.Dict[str, types.AttributeValue]
+        self, attributes: typing.Mapping[str, types.AttributeValue]
     ) -> None:
         pass
 

opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py

@@ -30,6 +30,7 @@
     Dict,
     Iterator,
     List,
+    Mapping,
     MutableMapping,
     Optional,
     Sequence,
@@ -842,7 +843,7 @@ def get_span_context(self):
         return self._context
 
     def set_attributes(
-        self, attributes: Dict[str, types.AttributeValue]
+        self, attributes: Mapping[str, types.AttributeValue]
     ) -> None:
         with self._lock:
             if self._end_time is not None: