Skip to content

Commit 5533b96

Browse files
committed
changelog and added tests
1 parent 63c9ab2 commit 5533b96

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

88
## Unreleased
9+
- Add `attributes` field in `metrics.get_meter` wrapper function
10+
([#4364](https://github.com/open-telemetry/opentelemetry-python/pull/4364))
911

1012
## Version 1.29.0/0.50b0 (2024-12-11)
1113

opentelemetry-api/tests/metrics/test_meter_provider.py

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
get_meter_provider,
3030
set_meter_provider,
3131
)
32-
from opentelemetry.metrics._internal import _ProxyMeter, _ProxyMeterProvider
32+
from opentelemetry.metrics._internal import _ProxyMeter, _ProxyMeterProvider, get_meter
3333
from opentelemetry.metrics._internal.instrument import (
3434
_ProxyCounter,
3535
_ProxyGauge,
@@ -140,6 +140,25 @@ def test_invalid_name(self):
140140
self.assertTrue(isinstance(meter, NoOpMeter))
141141

142142
self.assertEqual(meter.name, None)
143+
144+
def test_get_meter_wrapper(self):
145+
"""
146+
`metrics._internal.get_meter` called with valid parameters and a NoOpMeterProvider
147+
should return a NoOpMeter with the same parameters.
148+
"""
149+
150+
meter = get_meter(
151+
"name",
152+
version = "version",
153+
meter_provider = NoOpMeterProvider(),
154+
schema_url = "schema_url",
155+
attributes = {"key": "value", "key2": 5, "key3": "value3"},
156+
)
157+
158+
self.assertIsInstance(meter, NoOpMeter)
159+
self.assertEqual(meter.name, "name")
160+
self.assertEqual(meter.version, "version")
161+
self.assertEqual(meter.schema_url, "schema_url")
143162

144163

145164
class TestProxy(MetricsGlobalsTest, TestCase):

0 commit comments

Comments
 (0)