Fix events tests

Author: hectorhdzg

opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py

@@ -15,6 +15,7 @@
 from time import time_ns
 from typing import Optional
 
+from opentelemetry import trace
 from opentelemetry._events import Event
 from opentelemetry._events import EventLogger as APIEventLogger
 from opentelemetry._events import EventLoggerProvider as APIEventLoggerProvider
@@ -53,10 +54,20 @@ def emit(self, event: Event) -> None:
         if isinstance(self._logger, NoOpLogger):
             # Do nothing if SDK is disabled
             return
-        # The Event is already an API LogRecord (it holds trace/span
-        # context and the event name). Forward it directly to the SDK
-        # logger so the original trace/span relationship is preserved.
-        self._logger.emit(event)
+        span_context = trace.get_current_span().get_span_context()
+        log_record = LogRecord(
+            timestamp=event.timestamp or time_ns(),
+            observed_timestamp=None,
+            trace_id=event.trace_id or span_context.trace_id,
+            span_id=event.span_id or span_context.span_id,
+            trace_flags=event.trace_flags or span_context.trace_flags,
+            severity_text=None,
+            severity_number=event.severity_number or SeverityNumber.INFO,
+            body=event.body,
+            resource=getattr(self._logger, "resource", None),
+            attributes=event.attributes,
+        )
+        self._logger.emit(log_record)
 
 
 class EventLoggerProvider(APIEventLoggerProvider):

opentelemetry-sdk/tests/events/test_events.py

@@ -107,7 +107,7 @@ def test_event_logger(self, logger_mock):
             "name", "version", "schema_url", {"key": "value"}
         )
 
-    @patch("opentelemetry.sdk._events.ReadWriteLogRecord")
+    @patch("opentelemetry.sdk._events.LogRecord")
     @patch("opentelemetry.sdk._logs._internal.LoggerProvider.get_logger")
     def test_event_logger_emit(self, logger_mock, log_record_mock):
         logger_provider = LoggerProvider()
@@ -143,9 +143,25 @@ def test_event_logger_emit(self, logger_mock, log_record_mock):
         log_record_mock_inst = Mock()
         log_record_mock.return_value = log_record_mock_inst
         event_logger.emit(event)
+        log_record_mock.assert_called_once_with(
+            timestamp=now,
+            observed_timestamp=None,
+            trace_id=trace_id,
+            span_id=span_id,
+            trace_flags=trace_flags,
+            severity_text=None,
+            severity_number=SeverityNumber.ERROR,
+            body="test body",
+            resource=event_logger._logger.resource,
+            attributes={
+                "key": "val",
+                "foo": "bar",
+                "event.name": "test_event",
+            },
+        )
         logger_mock_inst.emit.assert_called_once_with(log_record_mock_inst)
 
-    @patch("opentelemetry.sdk._events.ReadWriteLogRecord")
+    @patch("opentelemetry.sdk._events.LogRecord")
     @patch("opentelemetry.sdk._logs._internal.LoggerProvider.get_logger")
     def test_event_logger_emit_sdk_disabled(
         self, logger_mock, log_record_mock