Fix a bunch of failing style/lint/spellcheck checks

Author: DylanRussell

exporter/opentelemetry-exporter-opencensus/src/opentelemetry/exporter/opencensus/trace_exporter/__init__.py

@@ -69,6 +69,7 @@ def __init__(
         self.host_name = host_name
         self.node = utils.get_node(service_name, host_name)
 
+    # pylint: disable=arguments-differ
     def export(self, spans: Sequence[ReadableSpan]) -> SpanExportResult:
         # Populate service_name from first span
         # We restrict any SpanProcessor to be only associated with a single

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py

@@ -72,7 +72,7 @@
 from opentelemetry.sdk.trace import ReadableSpan
 from opentelemetry.util.re import parse_env_headers
 
-json_config = json.dumps(
+_JSON_CONFIG = json.dumps(
     {
         "methodConfig": [
             {
@@ -269,7 +269,7 @@ def __init__(
                 self._endpoint,
                 compression=compression,
                 options=[
-                    ("grpc.service_config", json_config),
+                    ("grpc.service_config", _JSON_CONFIG),
                 ],
             )
         else:
@@ -284,7 +284,7 @@ def __init__(
                 credentials,
                 compression=compression,
                 options=[
-                    ("grpc.service_config", json_config),
+                    ("grpc.service_config", _JSON_CONFIG),
                 ],
             )
         self._client = self._stub(self._channel)

exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_exporter_mixin.py

@@ -20,7 +20,12 @@
 from unittest import TestCase
 from unittest.mock import ANY, Mock, patch
 
-from google.rpc import code_pb2, status_pb2
+from google.rpc.code_pb2 import (  # pylint: disable=no-name-in-module
+    ALREADY_EXISTS,
+    OK,
+    UNAVAILABLE,
+)
+from google.rpc.status_pb2 import Status  # pylint: disable=no-name-in-module
 from grpc import Compression, server
 from grpc_status import rpc_status
 
@@ -91,21 +96,21 @@ def shutdown(self, timeout_millis=30_000):
 class TraceServiceServicerWithExportParams(TraceServiceServicer):
     def __init__(
         self,
-        export_result: code_pb2,
+        export_result: int,
         optional_export_sleep: Optional[float] = None,
     ):
         self.export_result = export_result
         self.optional_export_sleep = optional_export_sleep
 
     # pylint: disable=invalid-name,unused-argument
     def Export(self, request, context):
-        logger.warning("Export Request Recieved")
+        logger.warning("Export Request Received")
         if self.optional_export_sleep:
             time.sleep(self.optional_export_sleep)
-        if self.export_result != code_pb2.OK:
+        if self.export_result != OK:
             context.abort_with_status(
                 rpc_status.to_status(
-                    status_pb2.Status(
+                    Status(
                         code=self.export_result,
                     )
                 )
@@ -288,7 +293,7 @@ def test_otlp_exporter_otlp_compression_envvar(
 
     def test_shutdown(self):
         add_TraceServiceServicer_to_server(
-            TraceServiceServicerWithExportParams(code_pb2.OK),
+            TraceServiceServicerWithExportParams(OK),
             self.server,
         )
         self.assertEqual(
@@ -306,9 +311,7 @@ def test_shutdown(self):
 
     def test_shutdown_wait_last_export(self):
         add_TraceServiceServicer_to_server(
-            TraceServiceServicerWithExportParams(
-                code_pb2.OK, optional_export_sleep=1
-            ),
+            TraceServiceServicerWithExportParams(OK, optional_export_sleep=1),
             self.server,
         )
 
@@ -327,9 +330,7 @@ def test_shutdown_wait_last_export(self):
 
     def test_shutdown_doesnot_wait_last_export(self):
         add_TraceServiceServicer_to_server(
-            TraceServiceServicerWithExportParams(
-                code_pb2.OK, optional_export_sleep=3
-            ),
+            TraceServiceServicerWithExportParams(OK, optional_export_sleep=3),
             self.server,
         )
 
@@ -351,7 +352,7 @@ def test_export_over_closed_grpc_channel(self):
         # pylint: disable=protected-access
 
         add_TraceServiceServicer_to_server(
-            TraceServiceServicerWithExportParams(code_pb2.OK),
+            TraceServiceServicerWithExportParams(OK),
             self.server,
         )
         self.exporter.export([self.span])
@@ -365,7 +366,7 @@ def test_export_over_closed_grpc_channel(self):
 
     def test_retry_timeout(self):
         add_TraceServiceServicer_to_server(
-            TraceServiceServicerWithExportParams(code_pb2.UNAVAILABLE),
+            TraceServiceServicerWithExportParams(UNAVAILABLE),
             self.server,
         )
         with self.assertLogs(level=WARNING) as warning:
@@ -381,7 +382,7 @@ def test_retry_timeout(self):
             for idx, log in enumerate(warning.records):
                 if idx != 2:
                     self.assertEqual(
-                        "Export Request Recieved",
+                        "Export Request Received",
                         log.message,
                     )
                 else:
@@ -405,7 +406,7 @@ def test_retry_timeout(self):
             for idx, log in enumerate(warning.records):
                 if idx != 3:
                     self.assertEqual(
-                        "Export Request Recieved",
+                        "Export Request Received",
                         log.message,
                     )
                 else:
@@ -417,7 +418,7 @@ def test_retry_timeout(self):
     def test_timeout_set_correctly(self):
         add_TraceServiceServicer_to_server(
             TraceServiceServicerWithExportParams(
-                code_pb2.OK, optional_export_sleep=0.5
+                OK, optional_export_sleep=0.5
             ),
             self.server,
         )
@@ -449,7 +450,7 @@ def test_otlp_headers_from_env(self):
     def test_permanent_failure(self):
         with self.assertLogs(level=WARNING) as warning:
             add_TraceServiceServicer_to_server(
-                TraceServiceServicerWithExportParams(code_pb2.ALREADY_EXISTS),
+                TraceServiceServicerWithExportParams(ALREADY_EXISTS),
                 self.server,
             )
             self.assertEqual(

exporter/opentelemetry-exporter-zipkin-json/src/opentelemetry/exporter/zipkin/json/__init__.py

@@ -149,6 +149,7 @@ def __init__(
             environ.get(OTEL_EXPORTER_ZIPKIN_TIMEOUT, 10)
         )
 
+    # pylint: disable=arguments-differ
     def export(self, spans: Sequence[Span]) -> SpanExportResult:
         # After the call to Shutdown subsequent calls to Export are
         # not allowed and should return a Failure result

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py

@@ -79,7 +79,7 @@ def export(
 
         Args:
             batch: The list of `LogData` objects to be exported.
-            timeout_millis: Optional milliseconds until Export should timeout if it hasn't succeded.
+            timeout_millis: Optional milliseconds until Export should timeout if it hasn't succeeded.
 
         Returns:
             The result of the export
@@ -120,6 +120,7 @@ def export(self, batch: Sequence[LogData]):
     def shutdown(self):
         pass
 
+
 class SimpleLogRecordProcessor(LogRecordProcessor):
     """This is an implementation of LogRecordProcessor which passes
     received logs in the export-friendly LogData representation to the

opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py

@@ -77,13 +77,12 @@ def export(
 
         Args:
             spans: The list of `opentelemetry.trace.Span` objects to be exported
-            timeout_millis: Optional milliseconds until Export should timeout if it hasn't succeded.
+            timeout_millis: Optional milliseconds until Export should timeout if it hasn't succeeded.
 
         Returns:
             The result of the export
         """
 
-    @abc.abstractmethod
     def shutdown(self) -> None:
         """Shuts down the exporter.
 
@@ -522,8 +521,5 @@ def export(self, spans: typing.Sequence[ReadableSpan]) -> SpanExportResult:
         self.out.flush()
         return SpanExportResult.SUCCESS
 
-    def force_flush(self, timeout_millis: int = 30000):
+    def force_flush(self, timeout_millis: int = 30000) -> bool:
         return True
-
-    def shutdown(self):
-        pass

opentelemetry-sdk/src/opentelemetry/sdk/trace/export/in_memory_span_exporter.py

@@ -57,6 +57,3 @@ def shutdown(self) -> None:
         Calls to export after the exporter has been shut down will fail.
         """
         self._stopped = True
-
-    def force_flush(self, timeout_millis: int = 30000) -> bool:
-        return True

opentelemetry-sdk/tests/trace/export/test_export.py

@@ -76,9 +76,6 @@ def export(self, spans: trace.Span) -> export.SpanExportResult:
     def shutdown(self):
         self.is_shutdown = True
 
-    def force_flush(self, timeout_millis: int = 30000) -> bool:
-        return True
-
 
 class TestSimpleSpanProcessor(unittest.TestCase):
     def test_simple_span_processor(self):