Skip to content

Commit 60d1c55

Browse files
committed
Use explicit argument names
1 parent 24a996c commit 60d1c55

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

.github/scripts/update-version-patch.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,9 @@
33
sed -i "/\[stable\]/{n;s/version=.*/version=$1/}" eachdist.ini
44
sed -i "/\[prerelease\]/{n;s/version=.*/version=$2/}" eachdist.ini
55

6-
./scripts/eachdist.py update_patch_versions --versions $1,$2,$3,$4
6+
./scripts/eachdist.py update_patch_versions \
7+
--stable_version=$1 \
8+
--unstable_version=$2 \
9+
--stable_version_prev=$3 \
10+
--unstable_version_prev=$4
11+

scripts/eachdist.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ def setup_instparser(instparser):
246246
patchreleaseparser.add_argument("--stable_version_prev", required=True)
247247
patchreleaseparser.add_argument("--unstable_version_prev", required=True)
248248

249-
250249
fmtparser = subparsers.add_parser(
251250
"format",
252251
help="Formats all source code with black and isort.",
@@ -675,20 +674,23 @@ def patch_release_args(args):
675674
targets = list(find_targets_unordered(rootpath))
676675
cfg = ConfigParser()
677676
cfg.read(str(find_projectroot() / "eachdist.ini"))
678-
versions = args.versions.split(",")
679677
# stable
680678
mcfg = cfg["stable"]
681679
packages = mcfg["packages"].split()
682-
print(f"update stable packages to {versions[0]}")
683-
update_patch_dependencies(targets, versions[0], versions[2], packages)
684-
update_version_files(targets, versions[0], packages)
680+
print(f"update stable packages to {args.stable_version}")
681+
update_patch_dependencies(
682+
targets, args.stable_version, args.stable_version_prev, packages
683+
)
684+
update_version_files(targets, args.stable_version, packages)
685685

686686
# prerelease
687687
mcfg = cfg["prerelease"]
688688
packages = mcfg["packages"].split()
689-
print(f"update prerelease packages to {versions[1]}")
690-
update_patch_dependencies(targets, versions[1], versions[3], packages)
691-
update_version_files(targets, versions[1], packages)
689+
print(f"update prerelease packages to {args.unstable_version}")
690+
update_patch_dependencies(
691+
targets, args.unstable_version, args.unstable_version_prev, packages
692+
)
693+
update_version_files(targets, args.unstable_version, packages)
692694

693695

694696
def test_args(args):

0 commit comments

Comments
 (0)