Skip to content

Commit 615d467

Browse files
anuraagaxrmx
andauthored
test-util: allow filtering metrics by scope (#4883)
* test-util: allow filtering metrics by scope * Apply suggestions from code review --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
1 parent 0018c00 commit 615d467

File tree

1 file changed

+9
-1
lines changed
  • tests/opentelemetry-test-utils/src/opentelemetry/test

1 file changed

+9
-1
lines changed

tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,13 @@ def disable_logging(highest_level=logging.CRITICAL):
142142
finally:
143143
logging.disable(logging.NOTSET)
144144

145-
def get_sorted_metrics(self):
145+
def get_sorted_metrics(self, scope: Optional[str] = None):
146+
"""Returns recorded metrics sorted by name.
147+
148+
Args:
149+
scope: Optional scope name to filter metrics by. If unset,
150+
all metrics are returned.
151+
"""
146152
metrics_data = self.memory_metrics_reader.get_metrics_data()
147153
resource_metrics = (
148154
metrics_data.resource_metrics if metrics_data else []
@@ -151,6 +157,8 @@ def get_sorted_metrics(self):
151157
all_metrics = []
152158
for metrics in resource_metrics:
153159
for scope_metrics in metrics.scope_metrics:
160+
if scope is not None and scope_metrics.scope.name != scope:
161+
continue
154162
all_metrics.extend(scope_metrics.metrics)
155163

156164
return self.sorted_metrics(all_metrics)

0 commit comments

Comments
 (0)