Skip to content

Commit 75fb724

Browse files
committed
Fix lint
1 parent 91f8460 commit 75fb724

File tree

2 files changed

+45
-12
lines changed

2 files changed

+45
-12
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -935,13 +935,23 @@ def std_to_otel(levelno: int) -> SeverityNumber:
935935
return SeverityNumber.FATAL4
936936
return _STD_TO_OTEL[levelno]
937937

938-
def is_less_than_min_severity(record: LogRecord, min_severity: SeverityNumber) -> bool:
938+
939+
def is_less_than_min_severity(
940+
record: LogRecord, min_severity: SeverityNumber
941+
) -> bool:
939942
if record.severity_number is not None:
940-
if min_severity is not None and min_severity != SeverityNumber.UNSPECIFIED and record.severity_number.value < min_severity.value:
943+
if (
944+
min_severity is not None
945+
and min_severity != SeverityNumber.UNSPECIFIED
946+
and record.severity_number.value < min_severity.value
947+
):
941948
return True
942949
return False
943950

944-
def should_drop_logs_for_trace_based(record: LogRecord, trace_state_enabled: bool) -> bool:
951+
952+
def should_drop_logs_for_trace_based(
953+
record: LogRecord, trace_state_enabled: bool
954+
) -> bool:
945955
if trace_state_enabled:
946956
if record.context is not None:
947957
span = get_current_span(record.context)

opentelemetry-sdk/tests/logs/test_logs.py

Lines changed: 32 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ def test_get_logger(self):
7474
self.assertEqual(
7575
logger._instrumentation_scope.attributes, {"key": "value"}
7676
)
77-
self.assertEqual(logger._min_severity_level, SeverityNumber.UNSPECIFIED)
77+
self.assertEqual(
78+
logger._min_severity_level, SeverityNumber.UNSPECIFIED
79+
)
7880
self.assertFalse(logger._trace_based)
7981

8082
@patch.dict("os.environ", {OTEL_SDK_DISABLED: "true"})
@@ -85,7 +87,9 @@ def test_get_logger_with_sdk_disabled(self):
8587

8688
@patch.object(Resource, "create")
8789
def test_logger_provider_init(self, resource_patch):
88-
logger_provider = LoggerProvider(min_severity_level=SeverityNumber.DEBUG4, trace_based=True)
90+
logger_provider = LoggerProvider(
91+
min_severity_level=SeverityNumber.DEBUG4, trace_based=True
92+
)
8993
resource_patch.assert_called_once()
9094
self.assertIsNotNone(logger_provider._resource)
9195
self.assertTrue(
@@ -94,7 +98,9 @@ def test_logger_provider_init(self, resource_patch):
9498
SynchronousMultiLogRecordProcessor,
9599
)
96100
)
97-
self.assertEqual(logger_provider._min_severity_level, SeverityNumber.DEBUG4)
101+
self.assertEqual(
102+
logger_provider._min_severity_level, SeverityNumber.DEBUG4
103+
)
98104
self.assertTrue(logger_provider._trace_based)
99105
self.assertIsNotNone(logger_provider._at_exit_handler)
100106

@@ -205,7 +211,9 @@ def test_emit_logrecord_with_min_severity_filtering(self):
205211
log_record_processor_mock.on_emit.assert_called_once()
206212
log_data = log_record_processor_mock.on_emit.call_args.args[0]
207213
self.assertTrue(isinstance(log_data.log_record, LogRecord))
208-
self.assertEqual(log_data.log_record.severity_number, SeverityNumber.ERROR)
214+
self.assertEqual(
215+
log_data.log_record.severity_number, SeverityNumber.ERROR
216+
)
209217

210218
def test_emit_logrecord_with_min_severity_unspecified(self):
211219
"""Test that when min severity is UNSPECIFIED, all logs are emitted"""
@@ -233,7 +241,10 @@ def test_emit_logrecord_with_trace_based_filtering(self):
233241

234242
mock_context = Mock()
235243

236-
with patch('opentelemetry.sdk._logs._internal.get_current_span', return_value=mock_span):
244+
with patch(
245+
"opentelemetry.sdk._logs._internal.get_current_span",
246+
return_value=mock_span,
247+
):
237248
log_record = LogRecord(
238249
observed_timestamp=0,
239250
body="should be dropped",
@@ -267,7 +278,10 @@ def test_emit_logrecord_trace_filtering_disabled(self):
267278

268279
mock_context = Mock()
269280

270-
with patch('opentelemetry.sdk._logs._internal.get_current_span', return_value=mock_span):
281+
with patch(
282+
"opentelemetry.sdk._logs._internal.get_current_span",
283+
return_value=mock_span,
284+
):
271285
log_record = LogRecord(
272286
observed_timestamp=0,
273287
body="should be emitted when filtering disabled",
@@ -293,7 +307,10 @@ def test_emit_logrecord_trace_filtering_edge_cases(self):
293307

294308
mock_context = Mock()
295309

296-
with patch('opentelemetry.sdk._logs._internal.get_current_span', return_value=mock_span):
310+
with patch(
311+
"opentelemetry.sdk._logs._internal.get_current_span",
312+
return_value=mock_span,
313+
):
297314
log_record = LogRecord(
298315
observed_timestamp=0,
299316
body="invalid but sampled",
@@ -314,7 +331,10 @@ def test_emit_logrecord_trace_filtering_edge_cases(self):
314331
mock_span = Mock()
315332
mock_span.get_span_context.return_value = mock_span_context
316333

317-
with patch('opentelemetry.sdk._logs._internal.get_current_span', return_value=mock_span):
334+
with patch(
335+
"opentelemetry.sdk._logs._internal.get_current_span",
336+
return_value=mock_span,
337+
):
318338
log_record = LogRecord(
319339
observed_timestamp=0,
320340
body="valid but not sampled",
@@ -341,7 +361,10 @@ def test_emit_both_min_severity_and_trace_based_filtering(self):
341361

342362
mock_context = Mock()
343363

344-
with patch('opentelemetry.sdk._logs._internal.get_current_span', return_value=mock_span):
364+
with patch(
365+
"opentelemetry.sdk._logs._internal.get_current_span",
366+
return_value=mock_span,
367+
):
345368
log_record_info = LogRecord(
346369
observed_timestamp=0,
347370
body="info log line",

0 commit comments

Comments
 (0)