Feedback: drop warnings that have a deprecations

xrmx · xrmx · commit 7aac5b0d661c · 2025-10-14T11:10:04.000+02:00
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -147,12 +147,6 @@ def __init__(
             OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT,
         )
 
-        warnings.warn(
-            "LogLimits will be deprecated in 1.39.0 and then renamed to LogRecordLimits",
-            LogDeprecatedInitWarning,
-            stacklevel=0,
-        )
-
     def __repr__(self):
         return f"{type(self).__name__}(max_attributes={self.max_attributes}, max_attribute_length={self.max_attribute_length})"
 
@@ -370,7 +364,7 @@ def __init__(
         instrumentation_scope: InstrumentationScope,
     ):
         warnings.warn(
-            "LogData will be substituted in 1.39.0 by ReadWriteLogRecord and ReadableLogRecord",
+            "LogData will be removed in 1.39.0 and replaced by ReadWriteLogRecord and ReadableLogRecord",
             LogDeprecatedInitWarning,
             stacklevel=0,
         )
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py
@@ -17,7 +17,6 @@
 import enum
 import logging
 import sys
-import warnings
 from os import environ, linesep
 from typing import IO, Callable, Optional, Sequence
 
@@ -29,7 +28,6 @@
 )
 from opentelemetry.sdk._logs import (
     LogData,
-    LogDeprecatedInitWarning,
     LogRecord,
     LogRecordProcessor,
 )
@@ -99,12 +97,6 @@ def __init__(
         self.out = out
         self.formatter = formatter
 
-        warnings.warn(
-            "ConsoleLogExporter will be deprecated in 1.39.0 and then renamed to ConsoleLogRecordExporter",
-            LogDeprecatedInitWarning,
-            stacklevel=0,
-        )
-
     def export(self, batch: Sequence[LogData]):
         for data in batch:
             self.out.write(self.formatter(data.log_record))
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/in_memory_log_exporter.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/in_memory_log_exporter.py
@@ -14,9 +14,8 @@
 
 import threading
 import typing
-import warnings
 
-from opentelemetry.sdk._logs import LogData, LogDeprecatedInitWarning
+from opentelemetry.sdk._logs import LogData
 from opentelemetry.sdk._logs.export import LogExporter, LogExportResult
 
 
@@ -33,12 +32,6 @@ def __init__(self):
         self._lock = threading.Lock()
         self._stopped = False
 
-        warnings.warn(
-            "InMemoryLogExporter will be deprecated in 1.39.0 and then renamed to InMemoryLogRecordExporter",
-            LogDeprecatedInitWarning,
-            stacklevel=0,
-        )
-
     def clear(self) -> None:
         with self._lock:
             self._logs.clear()
diff --git a/opentelemetry-sdk/tests/logs/test_export.py b/opentelemetry-sdk/tests/logs/test_export.py
@@ -17,7 +17,6 @@
 import os
 import time
 import unittest
-import warnings
 from concurrent.futures import ThreadPoolExecutor
 from sys import version_info
 from unittest.mock import Mock, patch
@@ -28,7 +27,6 @@
 from opentelemetry.sdk import trace
 from opentelemetry.sdk._logs import (
     LogData,
-    LogDeprecatedInitWarning,
     LoggerProvider,
     LoggingHandler,
     LogRecord,
@@ -649,99 +647,3 @@ def formatter(record):  # pylint: disable=unused-argument
         exporter.export([EMPTY_LOG])
 
         mock_stdout.write.assert_called_once_with(mock_record_str)
-
-    def test_console_log_exporter_deprecated_warning(self):
-        """Test that ConsoleLogExporter initialization emits a deprecation warning."""
-        with warnings.catch_warnings(record=True) as cw:
-            warnings.simplefilter("always")
-            ConsoleLogExporter()
-
-        # Check that at least one LogDeprecatedInitWarning, was emitted
-        console_warnings = [
-            w for w in cw if isinstance(w.message, LogDeprecatedInitWarning)
-        ]
-        self.assertGreater(
-            len(console_warnings),
-            0,
-            "Expected at least one LogDeprecatedInitWarning",
-        )
-
-        # Check the message content of the warning
-        warning_message = str(console_warnings[0].message)
-        self.assertIn(
-            "ConsoleLogExporter will be deprecated in 1.39.0 and then renamed to ConsoleLogRecordExporter",
-            warning_message,
-        )
-
-    def test_console_log_exporter_deprecated_warning_once(self):
-        """Test that ConsoleLogExporter deprecation warning is only shown once due to simplefilter('once')."""
-        with warnings.catch_warnings(record=True) as cw:
-            # Multiple instantiations should only warn once due to simplefilter("once")
-            for _ in range(10):
-                ConsoleLogExporter()
-
-        # Check that exactly one LogDeprecatedInitWarning was emitted
-        console_warnings = [
-            w for w in cw if isinstance(w.message, LogDeprecatedInitWarning)
-        ]
-        self.assertEqual(
-            len(console_warnings),
-            1,
-            "Expected exactly one LogDeprecatedInitWarning due to simplefilter('once')",
-        )
-
-        # Check the message content
-        warning_message = str(console_warnings[0].message)
-        self.assertIn(
-            "ConsoleLogExporter will be deprecated in 1.39.0 and then renamed to ConsoleLogRecordExporter",
-            warning_message,
-        )
-
-
-class TestInMemoryLogExporterDeprecation(unittest.TestCase):
-    def test_in_memory_log_exporter_deprecated_warning(self):
-        """Test that InMemoryLogExporter initialization emits a deprecation warning."""
-        with warnings.catch_warnings(record=True) as cw:
-            warnings.simplefilter("always")
-            InMemoryLogExporter()
-
-        # Check that at least one LogDeprecatedInitWarning was emitted
-        in_memory_warnings = [
-            w for w in cw if isinstance(w.message, LogDeprecatedInitWarning)
-        ]
-        self.assertGreater(
-            len(in_memory_warnings),
-            0,
-            "Expected at least one LogDeprecatedInitWarning",
-        )
-
-        # Check the message content of the warning
-        warning_message = str(in_memory_warnings[0].message)
-        self.assertIn(
-            "InMemoryLogExporter will be deprecated in 1.39.0 and then renamed to InMemoryLogRecordExporter",
-            warning_message,
-        )
-
-    def test_in_memory_log_exporter_deprecated_warning_once(self):
-        """Test that InMemoryLogExporter deprecation warning is only shown once due to simplefilter('once')."""
-        with warnings.catch_warnings(record=True) as cw:
-            # Multiple instantiations should only warn once due to simplefilter("once")
-            for _ in range(10):
-                InMemoryLogExporter()
-
-        # Check that exactly one LogDeprecatedInitWarning was emitted
-        in_memory_warnings = [
-            w for w in cw if isinstance(w.message, LogDeprecatedInitWarning)
-        ]
-        self.assertEqual(
-            len(in_memory_warnings),
-            1,
-            "Expected exactly one LogDeprecatedInitWarning due to simplefilter('once')",
-        )
-
-        # Check the message content
-        warning_message = str(in_memory_warnings[0].message)
-        self.assertIn(
-            "InMemoryLogExporter will be deprecated in 1.39.0 and then renamed to InMemoryLogRecordExporter",
-            warning_message,
-        )
diff --git a/opentelemetry-sdk/tests/logs/test_log_limits.py b/opentelemetry-sdk/tests/logs/test_log_limits.py
@@ -13,10 +13,9 @@
 # limitations under the License.
 
 import unittest
-import warnings
 from unittest.mock import patch
 
-from opentelemetry.sdk._logs import LogDeprecatedInitWarning, LogLimits
+from opentelemetry.sdk._logs import LogLimits
 from opentelemetry.sdk._logs._internal import (
     _DEFAULT_OTEL_ATTRIBUTE_COUNT_LIMIT,
 )
@@ -71,43 +70,3 @@ def test_invalid_env_vars_raise(self):
                     str(error.exception),
                     f"Unexpected error message for {env_var}={bad_value}",
                 )
-
-    def test_log_limits_init_deprecated_warning(self):
-        """Test that LogLimits initialization emits a deprecation warning."""
-        with warnings.catch_warnings(record=True) as cw:
-            warnings.simplefilter("always")
-            LogLimits()
-
-        self.assertEqual(len(cw), 1)
-        self.assertIsInstance(cw[-1].message, LogDeprecatedInitWarning)
-        self.assertIn(
-            "LogLimits will be deprecated in 1.39.0 and then renamed to LogRecordLimits",
-            str(cw[-1].message),
-        )
-
-    def test_log_limits_init_deprecated_warning_with_params(self):
-        """Test that LogLimits initialization with parameters still emits a deprecation warning."""
-        with warnings.catch_warnings(record=True) as cw:
-            warnings.simplefilter("always")
-            LogLimits(max_attributes=10, max_attribute_length=100)
-
-        self.assertEqual(len(cw), 1)
-        self.assertIsInstance(cw[-1].message, LogDeprecatedInitWarning)
-        self.assertIn(
-            "LogLimits will be deprecated in 1.39.0 and then renamed to LogRecordLimits",
-            str(cw[-1].message),
-        )
-
-    def test_log_limits_init_deprecated_warning_once(self):
-        """Test that LogLimits deprecation warning is only shown once due to simplefilter('once')."""
-        with warnings.catch_warnings(record=True) as cw:
-            # Multiple instantiations should only warn once due to simplefilter("once")
-            for _ in range(10):
-                LogLimits()
-
-        self.assertEqual(len(cw), 1)
-        self.assertIsInstance(cw[-1].message, LogDeprecatedInitWarning)
-        self.assertIn(
-            "LogLimits will be deprecated in 1.39.0 and then renamed to LogRecordLimits",
-            str(cw[-1].message),
-        )
diff --git a/opentelemetry-sdk/tests/logs/test_log_record.py b/opentelemetry-sdk/tests/logs/test_log_record.py
@@ -189,7 +189,7 @@ def test_log_record_context_deprecated_init_warning(self):
                     for w in cw
                     if isinstance(w.message, LogDeprecatedInitWarning)
                 ]
-                self.assertEqual(len(context_deprecated_warnings), 3)
+                self.assertEqual(len(context_deprecated_warnings), 2)
 
                 # Check we have the expected message once
                 log_record_context_warning = [
@@ -209,7 +209,7 @@ def test_log_record_context_deprecated_init_warning(self):
         context_deprecated_warnings = [
             w for w in cw if isinstance(w.message, LogDeprecatedInitWarning)
         ]
-        self.assertEqual(len(context_deprecated_warnings), 2)
+        self.assertEqual(len(context_deprecated_warnings), 1)
 
         # Check we have no message
         log_record_context_warning = [
