Skip to content

Commit 7f797a5

Browse files
committed
fix: update tracecontext integration test gitref
Update gitref to latest from https://github.com/w3c/trace-context Skip changed test that is incompatible with our implementation Add fixme comment to track setting flags for the test suite when they are available
1 parent f42041a commit 7f797a5

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

scripts/tracecontext-integration-test.sh

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22
set -e
33
# hard-coding the git tag to ensure stable builds.
4-
TRACECONTEXT_GIT_TAG="98f210efd89c63593dce90e2bae0a1bdcb986f51"
4+
TRACECONTEXT_GIT_TAG="d782773b2cf2fa4afd6a80a93b289d8a74ca894d"
55
# clone w3c tracecontext tests
66
mkdir -p target
77
rm -rf ./target/trace-context
@@ -24,4 +24,10 @@ onshutdown()
2424
}
2525
trap onshutdown EXIT
2626
cd ./target/trace-context/test
27-
python test.py http://127.0.0.1:5000/verify-tracecontext
27+
28+
# The disabled test is not compatible with an optional part of the W3C
29+
# spec that we have implemented (dropping duplicated keys from tracestate).
30+
# W3C are planning to include flags for optional features in the test suite.
31+
# https://github.com/w3c/trace-context/issues/529
32+
# FIXME: update test to use flags for optional features when available.
33+
python test.py http://127.0.0.1:5000/verify-tracecontext -k "not test_tracestate_duplicated_keys"

0 commit comments

Comments
 (0)