opentelemetry-sdk: clarify Resource.create usage (#4372)

* opentelemetry-sdk: clarify Resource.create usage

After #3181 ResourceDetector instances cannot call Resource.create
otherwise when using auto-instrumentation you'll go into an infinite loop
trying to load resource detectors.

* Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

Co-authored-by: Aaron Abbott <[email protected]>

* Update opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

Co-authored-by: Aaron Abbott <[email protected]>

* More precise instructions

---------

Co-authored-by: Aaron Abbott <[email protected]>

Author: xrmx

opentelemetry-sdk/src/opentelemetry/sdk/resources/__init__.py

@@ -23,7 +23,8 @@
     these attributes can be included in the Resource.*
 
 Resource objects are created with `Resource.create`, which accepts attributes
-(key-values). Resources should NOT be created via constructor, and working with
+(key-values). Resources should NOT be created via constructor except by `ResourceDetector`
+instances which can't use `Resource.create` to avoid infinite loops. Working with
 `Resource` objects should only be done via the Resource API methods. Resource
 attributes can also be passed at process invocation in the
 :envvar:`OTEL_RESOURCE_ATTRIBUTES` environment variable. You should register
@@ -175,6 +176,8 @@ def create(
     ) -> "Resource":
         """Creates a new `Resource` from attributes.
 
+        `ResourceDetector` instances should not call this method.
+
         Args:
             attributes: Optional zero or more key-value pairs.
             schema_url: Optional URL pointing to the schema
@@ -316,6 +319,7 @@ def __init__(self, raise_on_error: bool = False) -> None:
 
     @abc.abstractmethod
     def detect(self) -> "Resource":
+        """Don't call `Resource.create` here to avoid an infinite loop, instead instantiate `Resource` directly"""
         raise NotImplementedError()