Skip to content

Commit 95ccfea

Browse files
committed
Respond to review comments..
1 parent 66a4ebe commit 95ccfea

File tree

2 files changed

+6
-2
lines changed
  • exporter
    • opentelemetry-exporter-opencensus/src/opentelemetry/exporter/opencensus/trace_exporter
    • opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc

2 files changed

+6
-2
lines changed

exporter/opentelemetry-exporter-opencensus/src/opentelemetry/exporter/opencensus/trace_exporter/__init__.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ def __init__(
6969
self.host_name = host_name
7070
self.node = utils.get_node(service_name, host_name)
7171

72-
# pylint: disable=arguments-differ
7372
def export(self, spans: Sequence[ReadableSpan]) -> SpanExportResult:
7473
# Populate service_name from first span
7574
# We restrict any SpanProcessor to be only associated with a single

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,14 @@
7878
{
7979
"name": [dict()],
8080
"retryPolicy": {
81+
# 5 is the maximum allowable attempts allowed by grpc retry policy.
82+
# This policy results in backoffs of 1s, 2s, 4s, and then 8s after the initial failed attempt.
83+
# Timeout set on the RPC call encompasses the retry backoffs AND time spent waiting
84+
# for a response. DEADLINE_EXCEEDED is returned if all the attempts cannot complete within the
85+
# timeout. See https://grpc.io/docs/guides/retry/ for more details.
8186
"maxAttempts": 5,
8287
"initialBackoff": "1s",
83-
"maxBackoff": "64s",
88+
"maxBackoff": "9s",
8489
"backoffMultiplier": 2,
8590
"retryableStatusCodes": [
8691
"UNAVAILABLE",

0 commit comments

Comments
 (0)