Respond to comments

Author: DylanRussell

exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py

@@ -178,27 +178,27 @@ def _get_credentials(
 ) -> ChannelCredentials:
     if creds is not None:
         return creds
-    credential_env = environ.get(credential_entry_point_env_key)
-    if credential_env:
+    _credential_env = environ.get(credential_entry_point_env_key)
+    if _credential_env:
         try:
             maybe_channel_creds = next(
                 iter(
                     entry_points(
                         group="opentelemetry_otlp_credential_provider",
-                        name=credential_env,
+                        name=_credential_env,
                     )
                 )
             ).load()()
         except StopIteration:
             raise RuntimeError(
-                f"Requested component '{credential_env}' not found in "
+                f"Requested component '{_credential_env}' not found in "
                 f"entry point 'opentelemetry_otlp_credential_provider'"
             )
         if isinstance(maybe_channel_creds, ChannelCredentials):
             return maybe_channel_creds
         else:
             raise RuntimeError(
-                f"Requested component '{credential_env}' is of type {type(maybe_channel_creds)}"
+                f"Requested component '{_credential_env}' is of type {type(maybe_channel_creds)}"
                 f" must be of type `grpc.ChannelCredentials`."
             )
 

exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/_common/__init__.py

@@ -41,29 +41,29 @@ def _load_session_from_envvar(
         OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER,
     ],
 ) -> Optional[requests.Session]:
-    credential_env = environ.get(
+    _credential_env = environ.get(
         OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDER
     ) or environ.get(cred_envvar)
-    if credential_env:
+    if _credential_env:
         try:
             maybe_session = next(
                 iter(
                     entry_points(
                         group="opentelemetry_otlp_credential_provider",
-                        name=credential_env,
+                        name=_credential_env,
                     )
                 )
             ).load()()
         except StopIteration:
             raise RuntimeError(
-                f"Requested component '{credential_env}' not found in "
+                f"Requested component '{_credential_env}' not found in "
                 f"entry point 'opentelemetry_otlp_credential_provider'"
             )
         if isinstance(maybe_session, requests.Session):
             return maybe_session
         else:
             raise RuntimeError(
-                f"Requested component '{credential_env}' is of type {type(maybe_session)}"
+                f"Requested component '{_credential_env}' is of type {type(maybe_session)}"
                 f" must be of type `requests.Session`."
             )
     return None

opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py

@@ -410,6 +410,7 @@
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def channel_credential_provider() -> grpc.ChannelCredentials:
 
+Note: This environment variable is experimental and subject to change.
 """
 
 OTEL_PYTHON_EXPORTER_OTLP_HTTP_LOGS_CREDENTIAL_PROVIDER = (
@@ -428,6 +429,7 @@ def channel_credential_provider() -> grpc.ChannelCredentials:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def request_session_provder() -> requests.Session:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_HTTP_CREDENTIAL_PROVIDER"
@@ -445,6 +447,7 @@ def request_session_provder() -> requests.Session:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def request_session_provder() -> requests.Session:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_GRPC_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_GRPC_CREDENTIAL_PROVIDER"
@@ -462,6 +465,7 @@ def request_session_provder() -> requests.Session:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def channel_credential_provider() -> grpc.ChannelCredentials:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_HTTP_TRACES_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_HTTP_TRACES_CREDENTIAL_PROVIDER"
@@ -479,6 +483,7 @@ def channel_credential_provider() -> grpc.ChannelCredentials:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def request_session_provder() -> requests.Session:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_GRPC_TRACES_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_GRPC_TRACES_CREDENTIAL_PROVIDER"
@@ -496,6 +501,7 @@ def request_session_provder() -> requests.Session:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def channel_credential_provider() -> grpc.ChannelCredentials:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_HTTP_METRICS_CREDENTIAL_PROVIDER"
@@ -513,6 +519,7 @@ def channel_credential_provider() -> grpc.ChannelCredentials:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def request_session_provder() -> requests.Session:
 
+Note: This environment variable is experimental and subject to change.
 """
 OTEL_PYTHON_EXPORTER_OTLP_GRPC_METRICS_CREDENTIAL_PROVIDER = (
     "OTEL_PYTHON_EXPORTER_OTLP_GRPC_METRICS_CREDENTIAL_PROVIDER"
@@ -530,6 +537,7 @@ def request_session_provder() -> requests.Session:
     # Add a reference to this function under the `opentelemetry_otlp_credential_provider` entry point.
     def channel_credential_provider() -> grpc.ChannelCredentials:
 
+Note: This environment variable is experimental and subject to change.
 """
 
 OTEL_EXPORTER_OTLP_TRACES_CERTIFICATE = "OTEL_EXPORTER_OTLP_TRACES_CERTIFICATE"