Skip to content

Commit 9fe1f19

Browse files
authored
Cherry pick patch release workflow fixes from release branch (#4291)
1 parent ccc9e6f commit 9fe1f19

File tree

3 files changed

+70
-1
lines changed

3 files changed

+70
-1
lines changed
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
#!/bin/bash -e
2+
3+
sed -i "/\[stable\]/{n;s/version=.*/version=$1/}" eachdist.ini
4+
sed -i "/\[prerelease\]/{n;s/version=.*/version=$2/}" eachdist.ini
5+
6+
./scripts/eachdist.py update_patch_versions \
7+
--stable_version=$1 \
8+
--unstable_version=$2 \
9+
--stable_version_prev=$3 \
10+
--unstable_version_prev=$4
11+

.github/workflows/prepare-patch-release.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,18 @@ jobs:
4343
exit 1
4444
fi
4545
46+
stable_version_prev="$stable_major_minor.$((stable_patch))"
47+
unstable_version_prev="0.${unstable_minor}b$((unstable_patch))"
4648
stable_version="$stable_major_minor.$((stable_patch + 1))"
4749
unstable_version="0.${unstable_minor}b$((unstable_patch + 1))"
4850
4951
echo "STABLE_VERSION=$stable_version" >> $GITHUB_ENV
5052
echo "UNSTABLE_VERSION=$unstable_version" >> $GITHUB_ENV
53+
echo "STABLE_VERSION_PREV=$stable_version_prev" >> $GITHUB_ENV
54+
echo "UNSTABLE_VERSION_PREV=$unstable_version_prev" >> $GITHUB_ENV
5155
5256
- name: Update version
53-
run: .github/scripts/update-version.sh $STABLE_VERSION $UNSTABLE_VERSION
57+
run: .github/scripts/update-version-patch.sh $STABLE_VERSION $UNSTABLE_VERSION $STABLE_VERSION_PREV $UNSTABLE_VERSION_PREV
5458

5559
- name: Update the change log with the approximate release date
5660
run: |

scripts/eachdist.py

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,16 @@ def setup_instparser(instparser):
236236
"releaseargs", nargs=argparse.REMAINDER, help=extraargs_help("pytest")
237237
)
238238

239+
patchreleaseparser = subparsers.add_parser(
240+
"update_patch_versions",
241+
help="Updates version numbers during patch release, used by maintainers and CI",
242+
)
243+
patchreleaseparser.set_defaults(func=patch_release_args)
244+
patchreleaseparser.add_argument("--stable_version", required=True)
245+
patchreleaseparser.add_argument("--unstable_version", required=True)
246+
patchreleaseparser.add_argument("--stable_version_prev", required=True)
247+
patchreleaseparser.add_argument("--unstable_version_prev", required=True)
248+
239249
fmtparser = subparsers.add_parser(
240250
"format",
241251
help="Formats all source code with black and isort.",
@@ -599,6 +609,24 @@ def update_dependencies(targets, version, packages):
599609
)
600610

601611

612+
def update_patch_dependencies(targets, version, prev_version, packages):
613+
print("updating patch dependencies")
614+
# PEP 508 allowed specifier operators
615+
operators = ["==", "!=", "<=", ">=", "<", ">", "===", "~=", "="]
616+
operators_pattern = "|".join(re.escape(op) for op in operators)
617+
618+
for pkg in packages:
619+
search = rf"({basename(pkg)}[^,]*?)(\s?({operators_pattern})\s?)(.*{prev_version})"
620+
replace = r"\g<1>\g<2>" + version
621+
print(f"{search=}\t{replace=}\t{pkg=}")
622+
update_files(
623+
targets,
624+
"pyproject.toml",
625+
search,
626+
replace,
627+
)
628+
629+
602630
def update_files(targets, filename, search, replace):
603631
errors = False
604632
for target in targets:
@@ -640,6 +668,32 @@ def release_args(args):
640668
update_version_files(targets, version, packages)
641669

642670

671+
def patch_release_args(args):
672+
print("preparing patch release")
673+
674+
rootpath = find_projectroot()
675+
targets = list(find_targets_unordered(rootpath))
676+
cfg = ConfigParser()
677+
cfg.read(str(find_projectroot() / "eachdist.ini"))
678+
# stable
679+
mcfg = cfg["stable"]
680+
packages = mcfg["packages"].split()
681+
print(f"update stable packages to {args.stable_version}")
682+
update_patch_dependencies(
683+
targets, args.stable_version, args.stable_version_prev, packages
684+
)
685+
update_version_files(targets, args.stable_version, packages)
686+
687+
# prerelease
688+
mcfg = cfg["prerelease"]
689+
packages = mcfg["packages"].split()
690+
print(f"update prerelease packages to {args.unstable_version}")
691+
update_patch_dependencies(
692+
targets, args.unstable_version, args.unstable_version_prev, packages
693+
)
694+
update_version_files(targets, args.unstable_version, packages)
695+
696+
643697
def test_args(args):
644698
clean_remainder_args(args.pytestargs)
645699
execute_args(

0 commit comments

Comments
 (0)