Skip to content

Commit a78ffd7

Browse files
committed
fixing the for-loop
1 parent 0e5f610 commit a78ffd7

File tree

1 file changed

+21
-22
lines changed
  • opentelemetry-api/src/opentelemetry/propagate

1 file changed

+21
-22
lines changed

opentelemetry-api/src/opentelemetry/propagate/__init__.py

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -129,32 +129,31 @@ def inject(
129129
"tracecontext,baggage",
130130
)
131131

132+
# Simplified logic to handle "none" case
132133
if environ_propagators.lower() == "none":
133134
propagators = []
134135
else:
135-
propagators = environ_propagators.split(",")
136-
137-
for propagator in environ_propagators.split(","):
138-
propagator = propagator.strip()
139-
140-
try:
141-
propagators.append( # type: ignore
142-
next( # type: ignore
143-
iter( # type: ignore
144-
entry_points( # type: ignore
145-
group="opentelemetry_propagator",
146-
name=propagator,
136+
propagators = []
137+
for propagator in environ_propagators.split(","):
138+
propagator = propagator.strip()
139+
try:
140+
propagators.append( # type: ignore
141+
next( # type: ignore
142+
iter( # type: ignore
143+
entry_points( # type: ignore
144+
group="opentelemetry_propagator",
145+
name=propagator,
146+
)
147147
)
148-
)
149-
).load()()
150-
)
151-
except StopIteration:
152-
raise ValueError(
153-
f"Propagator {propagator} not found. It is either misspelled or not installed."
154-
)
155-
except Exception: # pylint: disable=broad-exception-caught
156-
logger.exception("Failed to load propagator: %s", propagator)
157-
raise
148+
).load()()
149+
)
150+
except StopIteration:
151+
raise ValueError(
152+
f"Propagator {propagator} not found. It is either misspelled or not installed."
153+
)
154+
except Exception: # pylint: disable=broad-exception-caught
155+
logger.exception("Failed to load propagator: %s", propagator)
156+
raise
158157

159158

160159
_HTTP_TEXT_FORMAT = composite.CompositePropagator(propagators) # type: ignore

0 commit comments

Comments
 (0)