Cleanup

Author: anuraaga

opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_composable.py

@@ -54,6 +54,8 @@ def sampling_intent(
         trace_state: TraceState | None,
     ) -> SamplingIntent:
         """Returns information to make a sampling decision."""
+        ... # pylint: disable=unnecessary-ellipsis
 
     def get_description(self) -> str:
         """Returns a description of the sampler."""
+        ... # pylint: disable=unnecessary-ellipsis

opentelemetry-sdk/src/opentelemetry/sdk/trace/_sampling_experimental/_trace_state.py

@@ -117,6 +117,8 @@ def _parse_th(value: str, default: int) -> int:
     except ValueError:
         return default
 
+    # th value is compressed by removing all trailing zeros,
+    # so we restore them to get the real value.
     trailing_zeros = _MAX_VALUE_LENGTH - len(value)
     return parsed << (trailing_zeros * 4)
 

opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py

@@ -435,7 +435,7 @@ def _get_from_env_or_default() -> Sampler:
 
     if trace_sampler in ("traceidratio", "parentbased_traceidratio"):
         try:
-            rate = float(os.getenv(OTEL_TRACES_SAMPLER_ARG))
+            rate = float(os.getenv(OTEL_TRACES_SAMPLER_ARG, ""))
         except (ValueError, TypeError):
             _logger.warning("Could not convert TRACES_SAMPLER_ARG to float.")
             rate = 1.0

pyproject.toml

@@ -113,7 +113,8 @@ exclude = [
   "opentelemetry-sdk/src/opentelemetry/sdk/_logs",
   "opentelemetry-sdk/src/opentelemetry/sdk/error_handler",
   "opentelemetry-sdk/src/opentelemetry/sdk/metrics",
-  "opentelemetry-sdk/src/opentelemetry/sdk/trace",
+  "opentelemetry-sdk/src/opentelemetry/sdk/trace/export",
+  "opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py",
   "opentelemetry-sdk/src/opentelemetry/sdk/util",
   "opentelemetry-sdk/benchmarks",
 ]