Update force_flush to return a bool. Currently force_flush ignores it's timeout which is bad, but the behavior before made even less sense..

Author: DylanRussell

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py

@@ -192,7 +192,7 @@ def emit(self, log_data: LogData) -> None:
     def shutdown(self):
         return self._batch_processor.shutdown()
 
-    def force_flush(self, timeout_millis: Optional[int] = None):
+    def force_flush(self, timeout_millis: Optional[int] = None) -> bool:
         return self._batch_processor.force_flush(timeout_millis)
 
     @staticmethod

opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py

@@ -191,8 +191,10 @@ def shutdown(self):
         self._worker_thread.join()
         self._exporter.shutdown()
 
-    def force_flush(self, timeout_millis: Optional[int] = None):
+    # TODO: Fix force flush so the timeout is used https://github.com/open-telemetry/opentelemetry-python/issues/4568.
+    def force_flush(self, timeout_millis: Optional[int] = None) -> bool:
         if self._shutdown:
-            return
+            return False
         # Blocking call to export.
         self._export(BatchExportStrategy.EXPORT_ALL)
+        return True

opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py

@@ -169,7 +169,7 @@ def __init__(
         )
 
         self._batch_processor = BatchProcessor(
-            span_exporter,
+            span_exporter,  # type: ignore [reportArgumentType]
             schedule_delay_millis,
             max_export_batch_size,
             export_timeout_millis,
@@ -190,7 +190,7 @@ def on_end(self, span: ReadableSpan) -> None:
     def shutdown(self):
         return self._batch_processor.shutdown()
 
-    def force_flush(self, timeout_millis: typing.Optional[int] = None):
+    def force_flush(self, timeout_millis: typing.Optional[int] = None) -> bool:
         return self._batch_processor.force_flush(timeout_millis)
 
     @staticmethod