🚑 Handle "LogRecord.exc_info" being a string

Author: jourdanrodrigues

opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

@@ -19,6 +19,7 @@
 import concurrent.futures
 import json
 import logging
+import sys
 import threading
 import traceback
 import warnings
@@ -568,8 +569,12 @@ def _get_attributes(record: logging.LogRecord) -> _ExtendedAttributes:
         attributes[code_attributes.CODE_FUNCTION_NAME] = record.funcName
         attributes[code_attributes.CODE_LINE_NUMBER] = record.lineno
 
+        if isinstance(record.exc_info, str):
+            record.exc_info = sys.exc_info()
+
         if record.exc_info:
             exctype, value, tb = record.exc_info
+
             if exctype is not None:
                 attributes[exception_attributes.EXCEPTION_TYPE] = (
                     exctype.__name__

opentelemetry-sdk/tests/logs/test_handler.py

@@ -14,6 +14,7 @@
 
 import logging
 import os
+import sys
 import unittest
 from unittest.mock import Mock, patch
 
@@ -48,6 +49,20 @@ def test_handler_default_log_level(self):
             logger.warning("Warning message")
         self.assertEqual(processor.emit_count(), 1)
 
+    def test_handler_error_exc_info(self):
+        processor, logger = set_up_test_logging(logging.NOTSET)
+        exc_info_values = [
+            # Don't know what caused it in my context, so I'm relying on mocks to replicate the behavior.
+            # First the `record.exc_info` becomes a string somehow, then `sys.exc_info` brings the tuple.
+            "Stringified exception",
+            (None, None, None),
+        ]
+
+        with patch.object(sys, "exc_info", side_effect=exc_info_values):
+            logger.exception("Exception message")  # Should not raise exception
+
+        assert processor.emit_count() == 1
+
     def test_handler_custom_log_level(self):
         processor, logger = set_up_test_logging(logging.ERROR)