Make trace_api.use_span() record BaseException as well as Exception

Author: tmaxwell-anthropic

opentelemetry-api/src/opentelemetry/trace/__init__.py

@@ -590,7 +590,7 @@ def use_span(
         finally:
             context_api.detach(token)
 
-    except Exception as exc:  # pylint: disable=broad-exception-caught
+    except BaseException as exc:  # pylint: disable=broad-exception-caught
         if isinstance(span, Span) and span.is_recording():
             # Record the exception as an event
             if record_exception:

opentelemetry-api/tests/trace/test_globals.py

@@ -133,6 +133,18 @@ class TestUseSpanException(Exception):
 
         self.assertEqual(test_span.recorded_exception, exception)
 
+    def test_use_span_base_exception(self):
+        class TestUseSpanBaseException(BaseException):
+            pass
+
+        test_span = SpanTest(trace.INVALID_SPAN_CONTEXT)
+        exception = TestUseSpanBaseException("test exception")
+        with self.assertRaises(TestUseSpanBaseException):
+            with trace.use_span(test_span):
+                raise exception
+
+        self.assertEqual(test_span.recorded_exception, exception)
+
     def test_use_span_set_status(self):
         class TestUseSpanException(Exception):
             pass