Test and fixes

Author: xrmx

opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py

@@ -214,7 +214,6 @@ def emit(
         record: "LogRecord",
     ) -> None: ...
 
-    @abstractmethod
     def emit(
         self,
         record: "LogRecord | None" = None,

opentelemetry-sdk/tests/logs/test_logs.py

@@ -18,7 +18,13 @@
 from unittest.mock import Mock, patch
 
 from opentelemetry._logs import LogRecord as APILogRecord
-from opentelemetry.sdk._logs import Logger, LoggerProvider, LogRecord
+from opentelemetry._logs import SeverityNumber
+from opentelemetry.context import get_current
+from opentelemetry.sdk._logs import (
+    Logger,
+    LoggerProvider,
+    LogRecord,
+)
 from opentelemetry.sdk._logs._internal import (
     NoOpLogger,
     SynchronousMultiLogRecordProcessor,
@@ -127,3 +133,29 @@ def test_can_emit_api_logrecord(self):
         log_record_processor_mock.on_emit.assert_called_once()
         log_data = log_record_processor_mock.on_emit.call_args.args[0]
         self.assertTrue(isinstance(log_data.log_record, LogRecord))
+
+    def test_can_emit_with_keywords_arguments(self):
+        logger, log_record_processor_mock = self._get_logger()
+
+        logger.emit(
+            timestamp=100,
+            observed_timestamp=101,
+            context=get_current(),
+            severity_number=SeverityNumber.WARN,
+            severity_text="warn",
+            body="a body",
+            attributes={"some": "attributes"},
+            event_name="event_name",
+        )
+        log_record_processor_mock.on_emit.assert_called_once()
+        log_data = log_record_processor_mock.on_emit.call_args.args[0]
+        log_record = log_data.log_record
+        self.assertTrue(isinstance(log_record, LogRecord))
+        self.assertEqual(log_record.timestamp, 100)
+        self.assertEqual(log_record.observed_timestamp, 101)
+        self.assertEqual(log_record.context, {})
+        self.assertEqual(log_record.severity_number, SeverityNumber.WARN)
+        self.assertEqual(log_record.severity_text, "warn")
+        self.assertEqual(log_record.body, "a body")
+        self.assertEqual(log_record.attributes, {"some": "attributes"})
+        self.assertEqual(log_record.event_name, "event_name")