Stop using assertNoLogs to have green tests on py < 3.10

Author: xrmx

opentelemetry-api/tests/metrics/test_meter.py

@@ -15,7 +15,7 @@
 
 from logging import WARNING
 from unittest import TestCase
-from unittest.mock import Mock
+from unittest.mock import Mock, patch
 
 from opentelemetry.metrics import Meter, NoOpMeter
 
@@ -82,8 +82,10 @@ def create_observable_up_down_counter(
 
 class TestMeter(TestCase):
     # pylint: disable=no-member
-    def test_repeated_instrument_names(self):
-        try:
+    # TODO: convert to assertNoLogs instead of mocking logger when 3.10 is baseline
+    @patch("opentelemetry.metrics._internal._logger")
+    def test_repeated_instrument_names(self, logger_mock):
+        with self.assertNotRaises(Exception):
             test_meter = NoOpMeter("name")
 
             test_meter.create_counter("counter")
@@ -95,32 +97,28 @@ def test_repeated_instrument_names(self):
             test_meter.create_observable_up_down_counter(
                 "observable_up_down_counter", Mock()
             )
-        except Exception as error:  # pylint: disable=broad-exception-caught
-            self.fail(f"Unexpected exception raised {error}")
 
         for instrument_name in [
             "counter",
             "up_down_counter",
             "histogram",
             "gauge",
         ]:
-            with self.assertNoLogs(level=WARNING):
-                getattr(test_meter, f"create_{instrument_name}")(
-                    instrument_name
-                )
+            getattr(test_meter, f"create_{instrument_name}")(instrument_name)
+            logger_mock.warning.assert_not_called()
 
         for instrument_name in [
             "observable_counter",
             "observable_gauge",
             "observable_up_down_counter",
         ]:
-            with self.assertNoLogs(level=WARNING):
-                getattr(test_meter, f"create_{instrument_name}")(
-                    instrument_name, Mock()
-                )
+            getattr(test_meter, f"create_{instrument_name}")(
+                instrument_name, Mock()
+            )
+            logger_mock.warning.assert_not_called()
 
     def test_repeated_instrument_names_with_different_advisory(self):
-        try:
+        with self.assertNotRaises(Exception):
             test_meter = NoOpMeter("name")
 
             test_meter.create_counter("counter")
@@ -132,8 +130,6 @@ def test_repeated_instrument_names_with_different_advisory(self):
             test_meter.create_observable_up_down_counter(
                 "observable_up_down_counter", Mock()
             )
-        except Exception as error:  # pylint: disable=broad-exception-caught
-            self.fail(f"Unexpected exception raised {error}")
 
         for instrument_name in [
             "counter",

opentelemetry-sdk/tests/metrics/test_metrics.py

@@ -431,7 +431,9 @@ class TestMeter(TestCase):
     def setUp(self):
         self.meter = Meter(Mock(), Mock())
 
-    def test_repeated_instrument_names(self):
+    # TODO: convert to assertNoLogs instead of mocking logger when 3.10 is baseline
+    @patch("opentelemetry.sdk.metrics._internal._logger")
+    def test_repeated_instrument_names(self, logger_mock):
         with self.assertNotRaises(Exception):
             self.meter.create_counter("counter")
             self.meter.create_up_down_counter("up_down_counter")
@@ -453,20 +455,18 @@ def test_repeated_instrument_names(self):
             "histogram",
             "gauge",
         ]:
-            with self.assertNoLogs(level=WARNING):
-                getattr(self.meter, f"create_{instrument_name}")(
-                    instrument_name
-                )
+            getattr(self.meter, f"create_{instrument_name}")(instrument_name)
+            logger_mock.warning.assert_not_called()
 
         for instrument_name in [
             "observable_counter",
             "observable_gauge",
             "observable_up_down_counter",
         ]:
-            with self.assertNoLogs(level=WARNING):
-                getattr(self.meter, f"create_{instrument_name}")(
-                    instrument_name, callbacks=[Mock()]
-                )
+            getattr(self.meter, f"create_{instrument_name}")(
+                instrument_name, callbacks=[Mock()]
+            )
+            logger_mock.warning.assert_not_called()
 
     def test_repeated_instrument_names_with_different_advisory(self):
         with self.assertNotRaises(Exception):