Skip to content

Commit d510c06

Browse files
committed
Use OTEL_PYTHON_LOG_LEVEL instead
1 parent 39169e7 commit d510c06

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL,
4848
OTEL_TRACES_SAMPLER,
4949
OTEL_TRACES_SAMPLER_ARG,
50-
OTEL_LOG_LEVEL,
50+
OTEL_PYTHON_LOG_LEVEL,
5151
OTEL_PYTHON_LOG_FORMAT,
5252
)
5353
from opentelemetry.sdk.metrics import MeterProvider
@@ -91,7 +91,7 @@
9191

9292
_OTEL_SAMPLER_ENTRY_POINT_GROUP = "opentelemetry_traces_sampler"
9393

94-
_OTEL_LOG_LEVEL_BY_NAME = {
94+
_OTEL_PYTHON_LOG_LEVEL_BY_NAME = {
9595
"notset": logging.NOTSET,
9696
"debug": logging.DEBUG,
9797
"info": logging.INFO,
@@ -144,7 +144,7 @@ def _get_id_generator() -> str:
144144
return environ.get(OTEL_PYTHON_ID_GENERATOR, _DEFAULT_ID_GENERATOR)
145145

146146
def _get_log_level() -> int:
147-
return _OTEL_LOG_LEVEL_BY_NAME.get(environ.get(OTEL_LOG_LEVEL, "notset").lower().strip(), logging.NOTSET)
147+
return _OTEL_PYTHON_LOG_LEVEL_BY_NAME.get(environ.get(OTEL_PYTHON_LOG_LEVEL, "notset").lower().strip(), logging.NOTSET)
148148

149149

150150
def _get_exporter_entry_point(
@@ -275,7 +275,7 @@ def _init_logging(
275275
logger_provider=provider
276276
)
277277
# Log level
278-
if OTEL_LOG_LEVEL in environ:
278+
if OTEL_PYTHON_LOG_LEVEL in environ:
279279
handler.setLevel(_get_log_level())
280280
# Log format
281281
if OTEL_PYTHON_LOG_FORMAT in environ:

opentelemetry-sdk/tests/test_configurator.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,7 @@ def test_logging_init_exporter(self):
687687
environ,
688688
{
689689
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
690-
"OTEL_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
690+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
691691
},
692692
clear=True,
693693
)
@@ -724,7 +724,7 @@ def test_logging_init_exporter_level_under(self, log_level_mock):
724724
environ,
725725
{
726726
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
727-
"OTEL_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
727+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
728728
},
729729
clear=True,
730730
)
@@ -827,35 +827,35 @@ def test_logging_init_exporter_without_handler_setup(self):
827827
self.fail()
828828

829829
@patch.dict(environ, {}, clear=True)
830-
def test_otel_log_level_by_name_default(self):
830+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_default(self):
831831
self.assertEqual(_get_log_level(), NOTSET)
832832

833-
@patch.dict(environ, {"OTEL_LOG_LEVEL": "NOTSET "}, clear=True)
834-
def test_otel_log_level_by_name_notset(self):
833+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "NOTSET "}, clear=True)
834+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_notset(self):
835835
self.assertEqual(_get_log_level(), NOTSET)
836836

837-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " DeBug "}, clear=True)
838-
def test_otel_log_level_by_name_debug(self):
837+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " DeBug "}, clear=True)
838+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_debug(self):
839839
self.assertEqual(_get_log_level(), DEBUG)
840840

841-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " info "}, clear=True)
842-
def test_otel_log_level_by_name_info(self):
841+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " info "}, clear=True)
842+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_info(self):
843843
self.assertEqual(_get_log_level(), INFO)
844844

845-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " warn"}, clear=True)
846-
def test_otel_log_level_by_name_warn(self):
845+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warn"}, clear=True)
846+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_warn(self):
847847
self.assertEqual(_get_log_level(), WARNING)
848848

849-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " warnING "}, clear=True)
850-
def test_otel_log_level_by_name_warning(self):
849+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warnING "}, clear=True)
850+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_warning(self):
851851
self.assertEqual(_get_log_level(), WARNING)
852852

853-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " eRroR"}, clear=True)
854-
def test_otel_log_level_by_name_error(self):
853+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " eRroR"}, clear=True)
854+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_error(self):
855855
self.assertEqual(_get_log_level(), ERROR)
856856

857-
@patch.dict(environ, {"OTEL_LOG_LEVEL": "foobar"}, clear=True)
858-
def test_otel_log_level_by_name_invalid(self):
857+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "foobar"}, clear=True)
858+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_invalid(self):
859859
self.assertEqual(_get_log_level(), NOTSET)
860860

861861
@patch.dict(

0 commit comments

Comments
 (0)