chore: update py version in lint workflow to 3.13

jomcgi · jomcgi · commit ee82a5cfe255 · 2025-02-27T11:00:44.000Z
This upgrade was delayed due to an issue where pylint
was unable to import collections.abc
Update references to 3.13 now that the underlying issue
has been resolved.
Add pylint disable comments for existing violations
diff --git a/.github/workflows/templates/lint.yml.j2 b/.github/workflows/templates/lint.yml.j2
@@ -24,10 +24,10 @@ jobs:
       - name: Checkout repo @ SHA - ${% raw %}{{ github.sha }}{% endraw %}
         uses: actions/checkout@v4
 
-      - name: Set up Python 3.12
+      - name: Set up Python 3.13
         uses: actions/setup-python@v5
         with:
-          python-version: "3.12"
+          python-version: "3.13"
 
       - name: Install tox
         run: pip install tox
diff --git a/exporter/opentelemetry-exporter-zipkin-json/src/opentelemetry/exporter/zipkin/json/__init__.py b/exporter/opentelemetry-exporter-zipkin-json/src/opentelemetry/exporter/zipkin/json/__init__.py
@@ -97,7 +97,7 @@
 
 
 class ZipkinExporter(SpanExporter):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         version: Protocol = Protocol.V2,
         endpoint: Optional[str] = None,
diff --git a/opentelemetry-api/src/opentelemetry/_events/__init__.py b/opentelemetry-api/src/opentelemetry/_events/__init__.py
@@ -31,7 +31,7 @@
 
 
 class Event(LogRecord):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         timestamp: Optional[int] = None,
diff --git a/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py b/opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
@@ -57,7 +57,7 @@ class LogRecord(ABC):
     pertinent to the event being logged.
     """
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         timestamp: Optional[int] = None,
         observed_timestamp: Optional[int] = None,
diff --git a/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py b/opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py
@@ -232,7 +232,7 @@ def schema_url(self) -> Optional[str]:
         """
         return self._schema_url
 
-    def _register_instrument(
+    def _register_instrument(  # pylint: disable=too-many-arguments
         self,
         name: str,
         type_: type,
diff --git a/opentelemetry-api/src/opentelemetry/trace/__init__.py b/opentelemetry-api/src/opentelemetry/trace/__init__.py
@@ -283,7 +283,7 @@ class Tracer(ABC):
     """
 
     @abstractmethod
-    def start_span(
+    def start_span(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[Context] = None,
@@ -338,7 +338,7 @@ def start_span(
 
     @_agnosticcontextmanager
     @abstractmethod
-    def start_as_current_span(
+    def start_as_current_span(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[Context] = None,
@@ -458,7 +458,7 @@ class NoOpTracer(Tracer):
     All operations are no-op.
     """
 
-    def start_span(
+    def start_span(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[Context] = None,
@@ -473,7 +473,7 @@ def start_span(
         return INVALID_SPAN
 
     @_agnosticcontextmanager
-    def start_as_current_span(
+    def start_as_current_span(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[Context] = None,
diff --git a/opentelemetry-api/src/opentelemetry/trace/span.py b/opentelemetry-api/src/opentelemetry/trace/span.py
@@ -438,7 +438,7 @@ class SpanContext(
         trace_state: Tracing-system-specific info to propagate.
     """
 
-    def __new__(
+    def __new__(  # pylint: disable=too-many-arguments
         cls,
         trace_id: int,
         span_id: int,
diff --git a/opentelemetry-api/tests/propagators/test_propagators.py b/opentelemetry-api/tests/propagators/test_propagators.py
@@ -134,7 +134,7 @@ def traceparent_helper(
 
         return context
 
-    def traceparent_helper_generator(
+    def traceparent_helper_generator(  # pylint: disable=too-many-arguments
         self,
         version=0x00,
         trace_id=0x00000000000000000000000000000001,
@@ -146,7 +146,7 @@ def traceparent_helper_generator(
         carrier = {"traceparent": traceparent}
         return self.traceparent_helper(carrier)
 
-    def valid_traceparent_helper(
+    def valid_traceparent_helper(  # pylint: disable=too-many-arguments
         self,
         version=0x00,
         trace_id=0x00000000000000000000000000000001,
@@ -188,7 +188,7 @@ def valid_traceparent_helper(
 
         return context, span, span_context
 
-    def invalid_traceparent_helper(
+    def invalid_traceparent_helper(  # pylint: disable=too-many-arguments
         self,
         version=0x00,
         trace_id=0x00000000000000000000000000000001,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py
@@ -359,7 +359,7 @@ def _import_id_generator(id_generator_name: str) -> IdGenerator:
     raise RuntimeError(f"{id_generator_name} is not an IdGenerator")
 
 
-def _initialize_components(
+def _initialize_components(  # pylint: disable=too-many-arguments
     auto_instrumentation_version: Optional[str] = None,
     trace_exporter_names: Optional[List[str]] = None,
     metric_exporter_names: Optional[List[str]] = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_events/__init__.py
@@ -27,7 +27,7 @@
 
 
 class EventLogger(APIEventLogger):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         logger_provider: LoggerProvider,
         name: str,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -170,7 +170,7 @@ class LogRecord(APILogRecord):
     pertinent to the event being logged.
     """
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         timestamp: Optional[int] = None,
         observed_timestamp: Optional[int] = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py
@@ -168,7 +168,7 @@ class BatchLogRecordProcessor(LogRecordProcessor):
     _flush_request: Optional[_FlushRequest]
     _log_records: List[Optional[LogData]]
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         exporter: LogExporter,
         schedule_delay_millis: float = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py
@@ -409,7 +409,7 @@ class MeterProvider(APIMeterProvider):
     _all_metric_readers_lock = Lock()
     _all_metric_readers = weakref.WeakSet()
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         metric_readers: Sequence[
             "opentelemetry.sdk.metrics.export.MetricReader"
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
@@ -163,7 +163,7 @@ def collect(
 
 
 class _SumAggregation(_Aggregation[Sum]):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         attributes: Attributes,
         instrument_is_monotonic: bool,
@@ -465,7 +465,7 @@ def collect(
 
 
 class _ExplicitBucketHistogramAggregation(_Aggregation[HistogramPoint]):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         attributes: Attributes,
         instrument_aggregation_temporality: AggregationTemporality,
@@ -625,7 +625,7 @@ class _ExponentialBucketHistogramAggregation(_Aggregation[HistogramPoint]):
     # giant exponential bucket histograms.
     _max_max_size = 16384
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         attributes: Attributes,
         reservoir_builder: ExemplarReservoirBuilder,
@@ -1129,7 +1129,7 @@ def _downscale(change: int, positive, negative):
         positive.downscale(change)
         negative.downscale(change)
 
-    def _merge(
+    def _merge(  # pylint: disable=too-many-arguments
         self,
         previous_buckets: Buckets,
         current_buckets: Buckets,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py
@@ -47,7 +47,7 @@
 
 
 class _Synchronous:
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         instrumentation_scope: InstrumentationScope,
@@ -79,7 +79,7 @@ def __init__(
 
 
 class _Asynchronous:
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         instrumentation_scope: InstrumentationScope,
@@ -222,7 +222,7 @@ def __new__(cls, *args, **kwargs):
 
 
 class Histogram(_Synchronous, APIHistogram):
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         instrumentation_scope: InstrumentationScope,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py
@@ -103,7 +103,7 @@ class View:
 
     _default_aggregation = DefaultAggregation()
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         instrument_type: Optional[Type[Instrument]] = None,
         instrument_name: Optional[str] = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -374,7 +374,7 @@ class ReadableSpan:
 
     """
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[trace_api.SpanContext] = None,
@@ -609,7 +609,7 @@ class SpanLimits:
 
     UNSET = -1
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         max_attributes: Optional[int] = None,
         max_events: Optional[int] = None,
@@ -761,7 +761,7 @@ def __new__(cls, *args, **kwargs):
         return super().__new__(cls)
 
     # pylint: disable=too-many-locals
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: trace_api.SpanContext,
@@ -1053,7 +1053,7 @@ class _Span(Span):
 class Tracer(trace_api.Tracer):
     """See `opentelemetry.trace.Tracer`."""
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         sampler: sampling.Sampler,
         resource: Resource,
@@ -1074,7 +1074,7 @@ def __init__(
         self._instrumentation_scope = instrumentation_scope
 
     @_agnosticcontextmanager  # pylint: disable=protected-access
-    def start_as_current_span(
+    def start_as_current_span(  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[context_api.Context] = None,
@@ -1104,7 +1104,7 @@ def start_as_current_span(
         ) as span:
             yield span
 
-    def start_span(  # pylint: disable=too-many-locals
+    def start_span(  # pylint: disable=too-many-locals  # pylint: disable=too-many-arguments
         self,
         name: str,
         context: Optional[context_api.Context] = None,
@@ -1184,7 +1184,7 @@ def start_span(  # pylint: disable=too-many-locals
 class TracerProvider(trace_api.TracerProvider):
     """See `opentelemetry.trace.TracerProvider`."""
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         sampler: Optional[sampling.Sampler] = None,
         resource: Optional[Resource] = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py
@@ -152,7 +152,7 @@ class BatchSpanProcessor(SpanProcessor):
     - :envvar:`OTEL_BSP_EXPORT_TIMEOUT`
     """
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         span_exporter: SpanExporter,
         max_queue_size: int = None,
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/sampling.py
@@ -197,7 +197,7 @@ def __init__(
 
 class Sampler(abc.ABC):
     @abc.abstractmethod
-    def should_sample(
+    def should_sample(  # pylint: disable=too-many-arguments
         self,
         parent_context: Optional["Context"],
         trace_id: int,
@@ -220,7 +220,7 @@ class StaticSampler(Sampler):
     def __init__(self, decision: "Decision") -> None:
         self._decision = decision
 
-    def should_sample(
+    def should_sample(  # pylint: disable=too-many-arguments
         self,
         parent_context: Optional["Context"],
         trace_id: int,
@@ -281,7 +281,7 @@ def rate(self) -> float:
     def bound(self) -> int:
         return self._bound
 
-    def should_sample(
+    def should_sample(  # pylint: disable=too-many-arguments
         self,
         parent_context: Optional["Context"],
         trace_id: int,
@@ -322,7 +322,7 @@ class ParentBased(Sampler):
             not sampled.
     """
 
-    def __init__(
+    def __init__(  # pylint: disable=too-many-arguments
         self,
         root: Sampler,
         remote_parent_sampled: Sampler = ALWAYS_ON,
@@ -336,7 +336,7 @@ def __init__(
         self._local_parent_sampled = local_parent_sampled
         self._local_parent_not_sampled = local_parent_not_sampled
 
-    def should_sample(
+    def should_sample(  # pylint: disable=too-many-arguments
         self,
         parent_context: Optional["Context"],
         trace_id: int,
diff --git a/opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py b/opentelemetry-sdk/tests/metrics/test_periodic_exporting_metric_reader.py
@@ -134,7 +134,7 @@ def test_defaults(self):
         with self.assertLogs(level=WARNING):
             pmr.shutdown()
 
-    def _create_periodic_reader(
+    def _create_periodic_reader(  # pylint: disable=too-many-arguments
         self, metrics, exporter, collect_wait=0, interval=60000, timeout=30000
     ):
         pmr = PeriodicExportingMetricReader(
diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -1910,7 +1910,7 @@ def test_dropped_attributes(self):
         self.assertEqual(2, span.events[0].dropped_attributes)
         self.assertEqual(2, span.links[0].dropped_attributes)
 
-    def _test_span_limits(
+    def _test_span_limits(  # pylint: disable=too-many-arguments
         self,
         tracer,
         max_attrs,
diff --git a/propagator/opentelemetry-propagator-jaeger/tests/test_jaeger_propagator.py b/propagator/opentelemetry-propagator-jaeger/tests/test_jaeger_propagator.py
@@ -85,7 +85,7 @@ def test_trace_id(self):
         old_carrier = {FORMAT.TRACE_ID_KEY: self.serialized_uber_trace_id}
         _, new_carrier = get_context_new_carrier(old_carrier)
         self.assertEqual(
-            self.serialized_uber_trace_id.split(":")[0],
+            self.serialized_uber_trace_id.split(":", maxsplit=1)[0],
             new_carrier[FORMAT.TRACE_ID_KEY].split(":")[0],
         )
 
diff --git a/shim/opentelemetry-opentracing-shim/src/opentelemetry/shim/opentracing_shim/__init__.py b/shim/opentelemetry-opentracing-shim/src/opentelemetry/shim/opentracing_shim/__init__.py
@@ -557,7 +557,7 @@ def unwrap(self):
 
         return self._otel_tracer
 
-    def start_active_span(
+    def start_active_span(  # pylint: disable=too-many-arguments
         self,
         operation_name: str,
         child_of: Union[SpanShim, SpanContextShim] = None,
@@ -611,7 +611,7 @@ def start_active_span(
         )
         return self._scope_manager.activate(span, finish_on_close)
 
-    def start_span(
+    def start_span(  # pylint: disable=too-many-arguments
         self,
         operation_name: str = None,
         child_of: Union[SpanShim, SpanContextShim] = None,
diff --git a/tests/opentelemetry-test-utils/src/opentelemetry/test/metrictestutil.py b/tests/opentelemetry-test-utils/src/opentelemetry/test/metrictestutil.py
