Fix lint errors

Author: sginji

docs/getting_started/tests/test_metrics.py

@@ -22,60 +22,53 @@ class TestMetrics(unittest.TestCase):
     def test_metrics(self):
         """Test that metrics example produces expected values"""
         # Run the metrics example
-        dirpath = os.path.dirname(os.path.realpath(__file__))
-        test_script = f"{dirpath}/../metrics_example.py"
-        
+        test_script = f"{os.path.dirname(os.path.realpath(__file__))}/../metrics_example.py"
+
         result = subprocess.run(
             [sys.executable, test_script],
             capture_output=True,
             text=True,
-            timeout=10
+            timeout=10,
+            check=True,
         )
-        
+
         # Script should run successfully
         self.assertEqual(result.returncode, 0)
-        
+
         # Parse the JSON output
         output_data = json.loads(result.stdout)
-        
+
         # Get the metrics from the JSON structure
         metrics = output_data["resource_metrics"][0]["scope_metrics"][0]["metrics"]
-        
+
         # Create a lookup dict for easier testing
         metrics_by_name = {metric["name"]: metric for metric in metrics}
-        
+
         # Test Counter: should be 1 (called counter.add(1))
-        counter_metric = metrics_by_name["counter"]
-        counter_value = counter_metric["data"]["data_points"][0]["value"]
+        counter_value = metrics_by_name["counter"]["data"]["data_points"][0]["value"]
         self.assertEqual(counter_value, 1, "Counter should have value 1")
-        
+
         # Test UpDownCounter: should be -4 (1 + (-5) = -4)
-        updown_metric = metrics_by_name["updown_counter"]
-        updown_value = updown_metric["data"]["data_points"][0]["value"]
+        updown_value = metrics_by_name["updown_counter"]["data"]["data_points"][0]["value"]
         self.assertEqual(updown_value, -4, "UpDownCounter should have value -4")
-        
+
         # Test Histogram: should have count=1, sum=99.9
-        histogram_metric = metrics_by_name["histogram"]
-        histogram_data = histogram_metric["data"]["data_points"][0]
+        histogram_data = metrics_by_name["histogram"]["data"]["data_points"][0]
         self.assertEqual(histogram_data["count"], 1, "Histogram should have count 1")
         self.assertEqual(histogram_data["sum"], 99.9, "Histogram should have sum 99.9")
-        
+
         # Test Gauge: should be 1 (last value set)
-        gauge_metric = metrics_by_name["gauge"]
-        gauge_value = gauge_metric["data"]["data_points"][0]["value"]
+        gauge_value = metrics_by_name["gauge"]["data"]["data_points"][0]["value"]
         self.assertEqual(gauge_value, 1, "Gauge should have value 1")
-        
+
         # Test Observable Counter: should be 1 (from callback)
-        obs_counter_metric = metrics_by_name["observable_counter"]
-        obs_counter_value = obs_counter_metric["data"]["data_points"][0]["value"]
+        obs_counter_value = metrics_by_name["observable_counter"]["data"]["data_points"][0]["value"]
         self.assertEqual(obs_counter_value, 1, "Observable counter should have value 1")
-        
+
         # Test Observable UpDownCounter: should be -10 (from callback)
-        obs_updown_metric = metrics_by_name["observable_updown_counter"]
-        obs_updown_value = obs_updown_metric["data"]["data_points"][0]["value"]
+        obs_updown_value = metrics_by_name["observable_updown_counter"]["data"]["data_points"][0]["value"]
         self.assertEqual(obs_updown_value, -10, "Observable updown counter should have value -10")
-        
+
         # Test Observable Gauge: should be 9 (from callback)
-        obs_gauge_metric = metrics_by_name["observable_gauge"]
-        obs_gauge_value = obs_gauge_metric["data"]["data_points"][0]["value"]
+        obs_gauge_value = metrics_by_name["observable_gauge"]["data"]["data_points"][0]["value"]
         self.assertEqual(obs_gauge_value, 9, "Observable gauge should have value 9")

docs/getting_started/tests/test_otlpcollector.py

@@ -23,21 +23,21 @@ def test_otlpcollector(self):
         """Test that OTLP collector example outputs 'Hello world!'"""
         dirpath = os.path.dirname(os.path.realpath(__file__))
         test_script = f"{dirpath}/../otlpcollector_example.py"
-        
+
         # Run the script with a short timeout since it will retry forever
-        process = subprocess.Popen(
+        with subprocess.Popen(
             [sys.executable, test_script],
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
-            text=True
-        )
-        
-        # Wait 2 seconds then kill it (enough time to print "Hello world!")
-        try:
-            stdout, stderr = process.communicate(timeout=2)
-        except subprocess.TimeoutExpired:
-            process.kill()
-            stdout, stderr = process.communicate()
-        
+            text=True,
+        ) as process:
+
+            # Wait 2 seconds then kill it (enough time to print "Hello world!")
+            try:
+                stdout, _ = process.communicate(timeout=2)
+            except subprocess.TimeoutExpired:
+                process.kill()
+                stdout, _ = process.communicate()
+
         # Check that it printed the expected message
         self.assertIn("Hello world!", stdout)